tools/perf/benchmarks/system_health.py - Issue 1985633003: [system-health] Disable system_health.memory_mobile.reference on Nexus 5X

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/system_health.py

Issue 1985633003: [system-health] Disable system_health.memory_mobile.reference on Nexus 5X (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix syntax Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/benchmarks/system_health.py

diff --git a/tools/perf/benchmarks/system_health.py b/tools/perf/benchmarks/system_health.py

index 687a86729200c991b84dabaa2c14f827c194f8b0..8a76a6f509467e320de5137690d38a1056559512 100644

--- a/tools/perf/benchmarks/system_health.py

+++ b/tools/perf/benchmarks/system_health.py

@@ -88,4 +88,7 @@ class MobileMemorySystemHealth(_MemorySystemHealthBenchmark):

@classmethod

def ShouldDisable(cls, possible_browser):

- return possible_browser.platform.GetDeviceTypeName() == 'Desktop'

+ # http://crbug.com/612144 (reference on Nexus 5X).

+ return possible_browser.platform.GetDeviceTypeName() == 'Desktop' or (

+ possible_browser.browser_type == 'reference' and

+ possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X')

« no previous file with comments | « no previous file | no next file » | no next file with comments »