Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Side by Side Diff: tools/perf/benchmarks/system_health.py

Issue 1985633003: [system-health] Disable system_health.memory_mobile.reference on Nexus 5X (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix syntax Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from core import perf_benchmark 5 from core import perf_benchmark
6 from telemetry import benchmark 6 from telemetry import benchmark
7 from telemetry.timeline import tracing_category_filter 7 from telemetry.timeline import tracing_category_filter
8 from telemetry.web_perf import timeline_based_measurement 8 from telemetry.web_perf import timeline_based_measurement
9 import page_sets 9 import page_sets
10 10
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 def ShouldDisable(cls, possible_browser): 81 def ShouldDisable(cls, possible_browser):
82 return possible_browser.platform.GetDeviceTypeName() != 'Desktop' 82 return possible_browser.platform.GetDeviceTypeName() != 'Desktop'
83 83
84 84
85 class MobileMemorySystemHealth(_MemorySystemHealthBenchmark): 85 class MobileMemorySystemHealth(_MemorySystemHealthBenchmark):
86 """Mobile Chrome Memory System Health Benchmark.""" 86 """Mobile Chrome Memory System Health Benchmark."""
87 page_set = page_sets.MobileMemorySystemHealthStorySet 87 page_set = page_sets.MobileMemorySystemHealthStorySet
88 88
89 @classmethod 89 @classmethod
90 def ShouldDisable(cls, possible_browser): 90 def ShouldDisable(cls, possible_browser):
91 return possible_browser.platform.GetDeviceTypeName() == 'Desktop' 91 # http://crbug.com/612144 (reference on Nexus 5X).
92 return possible_browser.platform.GetDeviceTypeName() == 'Desktop' or (
93 possible_browser.browser_type == 'reference' and
94 possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X')
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698