Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 1985263002: Reland of land: Initialize and reset V4LocalDBManager. Instantiate V4Stores. (Closed)

Created:
4 years, 7 months ago by qyearsley
Modified:
4 years, 7 months ago
CC:
chromium-reviews, grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of land: Initialize and reset V4LocalDBManager. Instantiate V4Stores. (patchset #1 id:1 of https://codereview.chromium.org/1984283003/ ) Reason for revert: Revert didn't help the problem (tests still failing as before on https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29?numbuilds=50) Original issue's description: > Revert of Reland: Initialize and reset V4LocalDBManager. Instantiate V4Stores. (patchset #6 id:100001 of https://codereview.chromium.org/1983723002/ ) > > Reason for revert: > Speculative revert for http://crbug.com/612523; will re-land if that builder still fails the same tests after the revert > > Original issue's description: > > Reland: Initialize and reset V4LocalDBManager. Instantiate V4Stores. > > A rough sketch of how this works is here: https://goto.google.com/pver4-LoadUpdateDatabase-doc > > > > This relands https://codereview.chromium.org/1954393002 which was reverted by https://codereview.chromium.org/1983603002 > > > > Reason for failure: StopOnIOThread ran first and reset v4_update_protocol_manager_, which we were later tried to dereference in DatabaseReady() > > > > -- > > Original commit: http://crrev.com/32b9468ab5177534cb155b2d222611a6bca16c98 > > Which was reverted as: http://crrev.com/517133dfc95a9ca2b599bfe7452205e5b5d81fd4 > > > > This CL reverts commit http://crrev.com/517133dfc95a9ca2b599bfe7452205e5b5d81fd4 > > -- > > > > BUG=543161 > > > > Committed: https://crrev.com/26771182e06d28496aca4c73e095d3c9a43713ce > > Cr-Commit-Position: refs/heads/master@{#393989} > > TBR=shess@chromium.org,nparker@chromium.org,vakh@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=543161 > > Committed: https://crrev.com/ed2c1c1767e9eb657d804b32088ba141502b645e > Cr-Commit-Position: refs/heads/master@{#394227} TBR=shess@chromium.org,nparker@chromium.org,vakh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=543161 Committed: https://crrev.com/0c301ecdffa4dcd497a30661b716fb170a17c4d6 Cr-Commit-Position: refs/heads/master@{#394257}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -56 lines) Patch
M chrome/browser/safe_browsing/services_delegate_impl.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M components/safe_browsing_db.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/safe_browsing_db/BUILD.gn View 2 chunks +5 lines, -1 line 0 comments Download
M components/safe_browsing_db/v4_database.h View 3 chunks +32 lines, -9 lines 0 comments Download
M components/safe_browsing_db/v4_database.cc View 1 chunk +72 lines, -10 lines 0 comments Download
M components/safe_browsing_db/v4_local_database_manager.h View 4 chunks +21 lines, -4 lines 0 comments Download
M components/safe_browsing_db/v4_local_database_manager.cc View 5 chunks +75 lines, -11 lines 0 comments Download
M components/safe_browsing_db/v4_store.h View 1 chunk +17 lines, -0 lines 0 comments Download
A components/safe_browsing_db/v4_store.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M components/safe_browsing_db/v4_update_protocol_manager.h View 4 chunks +8 lines, -3 lines 0 comments Download
M components/safe_browsing_db/v4_update_protocol_manager.cc View 10 chunks +42 lines, -14 lines 0 comments Download
M components/safe_browsing_db/v4_update_protocol_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
qyearsley
Created Reland of land: Initialize and reset V4LocalDBManager. Instantiate V4Stores.
4 years, 7 months ago (2016-05-17 23:04:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1985263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1985263002/1
4 years, 7 months ago (2016-05-17 23:04:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 23:05:24 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0c301ecdffa4dcd497a30661b716fb170a17c4d6 Cr-Commit-Position: refs/heads/master@{#394257}
4 years, 7 months ago (2016-05-17 23:07:40 UTC) #5
hiroshige
4 years, 7 months ago (2016-05-19 07:15:40 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1997583002/ by hiroshige@chromium.org.

The reason for reverting is: Actually revert looks fixed the problem, according
to:
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...
Therefore speculatively reverting again.
.

Powered by Google App Engine
This is Rietveld 408576698