third_party/WebKit/Source/core/inspector/NetworkResourcesData.h - Issue 1985033003: [DevTools] Use registerWeakMembers in NetworkResourcesData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/NetworkResourcesData.h

Issue 1985033003: [DevTools] Use registerWeakMembers in NetworkResourcesData. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased, removed more code Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/NetworkResourcesData.h

diff --git a/third_party/WebKit/Source/core/inspector/NetworkResourcesData.h b/third_party/WebKit/Source/core/inspector/NetworkResourcesData.h

index bdb7c6070aa79b04c2a2a30a01ee26ef2fc61299..88a14621d56f64be176bc3d5ebdcec0c8ba2779d 100644

--- a/third_party/WebKit/Source/core/inspector/NetworkResourcesData.h

+++ b/third_party/WebKit/Source/core/inspector/NetworkResourcesData.h

@@ -82,7 +82,7 @@ public:

class ResourceData final : public GarbageCollectedFinalized<ResourceData> {

friend class NetworkResourcesData;

public:

- ResourceData(const String& requestId, const String& loaderId, const KURL&);

+ ResourceData(NetworkResourcesData*, const String& requestId, const String& loaderId, const KURL&);

String requestId() const { return m_requestId; }

String loaderId() const { return m_loaderId; }

@@ -135,7 +135,9 @@ public:

size_t dataLength() const;

void appendData(const char* data, size_t dataLength);

size_t decodeDataToContent();

+ void clearWeakMembers(Visitor*);

+ Member<NetworkResourcesData> m_networkResourcesData;

String m_requestId;

String m_loaderId;

String m_frameId;

@@ -172,7 +174,6 @@ public:

void maybeDecodeDataToContent(const String& requestId);

void addResource(const String& requestId, Resource*);

ResourceData const* data(const String& requestId);

- Vector<String> removeResource(Resource*);

void clear(const String& preservedLoaderId = String());

void setResourcesDataSizeLimits(size_t maximumResourcesContentSize, size_t maximumSingleResourceContentSize);