[Interpreter] Change LogicalNot to ToBooleanLogicalNot and add non-ToBoolean version.

[Interpreter] Change LogicalNot to ToBooleanLogicalNot and add non-ToBoolean version.

Makes LogicalNot bytecode not do the ToBoolean operation, and add support in the
peephole optimizer to choose between the appropriate bytecode depending upon
whether the previous bytecode emitted a boolean or not.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/8352ad50e651c223ee7472bd23cbdeadfbe08cf2
Cr-Commit-Position: refs/heads/master@{#36295}

[rmcilroy, 2016-05-17 11:40:17]

rmcilroy@chromium.org changed reviewers:
+ bmeurer@chromium.org, oth@chromium.org

[rmcilroy, 2016-05-17 11:40:18]

Orion, PTAL at interpreter changes.
Benedikt, PTAL at compiler changes.

Thanks.

[rmcilroy, 2016-05-17 11:40:31]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-17 11:40:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1985033002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1985033002/20001

[commit-bot: I haz the power, 2016-05-17 11:41:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 11:41:45]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/5833)
  v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/5809)
  v8_mac_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/1713)

[Benedikt Meurer, 2016-05-17 12:27:47]

LGTM on compiler.

[oth, 2016-05-17 12:50:46]

No problems with this CL, but I am wary of how many conditions we add to the
peephole optimizer. Is there any data about the scale of the win?

https://codereview.chromium.org/1985033002/diff/20001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/ForOf.golden (right):

https://codereview.chromium.org/1985033002/diff/20001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/ForOf.golden:667:
B(JumpIfFalseConstant), U8(11),
Opportunity for JumpIfToBooleanTrue.

[oth, 2016-05-17 15:07:51]

On 2016/05/17 12:50:46, oth wrote:
> No problems with this CL, but I am wary of how many conditions we add to the
> peephole optimizer. Is there any data about the scale of the win?
> 
>
https://codereview.chromium.org/1985033002/diff/20001/test/cctest/interpreter...
> File test/cctest/interpreter/bytecode_expectations/ForOf.golden (right):
> 
>
https://codereview.chromium.org/1985033002/diff/20001/test/cctest/interpreter...
> test/cctest/interpreter/bytecode_expectations/ForOf.golden:667:
> B(JumpIfFalseConstant), U8(11),
> Opportunity for JumpIfToBooleanTrue.

of course, lgtm.

[rmcilroy, 2016-05-17 16:25:47]

> No problems with this CL, but I am wary of how many conditions we add to the
> peephole optimizer. Is there any data about the scale of the win?

Seems to be around a 5% win on Octane - assuming I'm doing pivot tables right :)
https://docs.google.com/spreadsheets/d/1U-dwFnmAoUKoqgEYNdYkm6tlX-StToV9eHn9n...

Seems worth it to me, WDYT?

https://codereview.chromium.org/1985033002/diff/20001/test/cctest/interpreter...
File test/cctest/interpreter/bytecode_expectations/ForOf.golden (right):

https://codereview.chromium.org/1985033002/diff/20001/test/cctest/interpreter...
test/cctest/interpreter/bytecode_expectations/ForOf.golden:667:
B(JumpIfFalseConstant), U8(11),
On 2016/05/17 12:50:46, oth wrote:
> Opportunity for JumpIfToBooleanTrue.

Acknowledged.

[rmcilroy, 2016-05-17 16:41:25]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-17 16:41:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1985033002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1985033002/40001

[commit-bot: I haz the power, 2016-05-17 16:42:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 16:42:39]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/5845)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_mac_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/1741)
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/15361)

[rmcilroy, 2016-05-17 20:04:47]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2016-05-17 20:04:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, oth@chromium.org
Link to the patchset: https://codereview.chromium.org/1985033002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-05-17 20:04:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1985033002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1985033002/60001

[commit-bot: I haz the power, 2016-05-17 20:39:55]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-17 20:41:11]

Description was changed from

==========
[Interpreter] Change LogicalNot to ToBooleanLogicalNot and add non-ToBoolean
version.

Makes LogicalNot bytecode not do the ToBoolean operation, and add support in the
peephole optimizer to choose between the appropriate bytecode depending upon
whether the previous bytecode emitted a boolean or not.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Change LogicalNot to ToBooleanLogicalNot and add non-ToBoolean
version.

Makes LogicalNot bytecode not do the ToBoolean operation, and add support in the
peephole optimizer to choose between the appropriate bytecode depending upon
whether the previous bytecode emitted a boolean or not.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/8352ad50e651c223ee7472bd23cbdeadfbe08cf2
Cr-Commit-Position: refs/heads/master@{#36295}
==========

[commit-bot: I haz the power, 2016-05-17 20:41:13]

Patchset 4 (id:??) landed as
https://crrev.com/8352ad50e651c223ee7472bd23cbdeadfbe08cf2
Cr-Commit-Position: refs/heads/master@{#36295}