src/interpreter/bytecodes.cc - Issue 1985033002: [Interpreter] Change LogicalNot to ToBooleanLogicalNot and add non-ToBoolean version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/bytecodes.cc

Issue 1985033002: [Interpreter] Change LogicalNot to ToBooleanLogicalNot and add non-ToBoolean version. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/interpreter/bytecodes.cc

diff --git a/src/interpreter/bytecodes.cc b/src/interpreter/bytecodes.cc

index 6604191c5953cccaf137a938721692f0a9da596d..b56948a86cf192bd53ed3fd816c38941c5ce64b0 100644

--- a/src/interpreter/bytecodes.cc

+++ b/src/interpreter/bytecodes.cc

@@ -243,6 +243,7 @@ bool Bytecodes::WritesBooleanToAccumulator(Bytecode bytecode) {

switch (bytecode) {

case Bytecode::kLdaTrue:

case Bytecode::kLdaFalse:

+ case Bytecode::kToBooleanLogicalNot:

case Bytecode::kLogicalNot:

case Bytecode::kTestEqual:

case Bytecode::kTestNotEqual:

« no previous file with comments | « src/interpreter/bytecodes.h ('k') | src/interpreter/interpreter.h » ('j') | no next file with comments »