Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1984953005: Revert "Fix the browser crash when changing wallpaper with chrome.wallpaper API." (Closed)

Created:
4 years, 7 months ago by xdai1
Modified:
4 years, 7 months ago
Reviewers:
bshe
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Fix the browser crash when changing wallpaper with chrome.wallpaper API." This reverts commit 72f2683a0d2175b27d43f8fc91357af138a872c4. Revert reason: Detect memory leak in the test ExtensionApiTest.Wallpaper. BUG=608895 TBR=bshe@chromium.org Committed: https://crrev.com/0d83958df92063615a84019f689985c74da54f8b Cr-Commit-Position: refs/heads/master@{#394253}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -17 lines) Patch
M chrome/browser/chromeos/extensions/wallpaper_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/wallpaper/test.js View 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984953005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984953005/1
4 years, 7 months ago (2016-05-17 20:50:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 22:51:45 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 22:53:05 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0d83958df92063615a84019f689985c74da54f8b
Cr-Commit-Position: refs/heads/master@{#394253}

Powered by Google App Engine
This is Rietveld 408576698