chrome/browser/chromeos/extensions/wallpaper_api.cc - Issue 1984953005: Revert "Fix the browser crash when changing wallpaper with chrome.wallpaper API."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/wallpaper_api.cc

Issue 1984953005: Revert "Fix the browser crash when changing wallpaper with chrome.wallpaper API." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/extensions/wallpaper_api.cc

diff --git a/chrome/browser/chromeos/extensions/wallpaper_api.cc b/chrome/browser/chromeos/extensions/wallpaper_api.cc

index 2cc28ca1ef90f80b9bf5f5e09cc77157fc5acbff..5d16b287c3c909dd3ea118be8f87fa37374fa797 100644

--- a/chrome/browser/chromeos/extensions/wallpaper_api.cc

+++ b/chrome/browser/chromeos/extensions/wallpaper_api.cc

@@ -248,7 +248,7 @@ void WallpaperSetWallpaperFunction::ThumbnailGenerated(

extensions::EventRouter::Get(profile);

std::unique_ptr<base::ListValue> event_args(new base::ListValue());

event_args->Append(original_result);

- event_args->Append(thumbnail_result->DeepCopy());

+ event_args->Append(thumbnail_result);

event_args->Append(new base::StringValue(

extensions::api::wallpaper::ToString(params_->details.layout)));

// Setting wallpaper from right click menu in 'Files' app is a feature that

« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/wallpaper/test.js » ('j') | no next file with comments »