Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1984953002: Use root_out_dir for lib_dirs when building with a custom libc++. (Closed)

Created:
4 years, 7 months ago by Sam McNally
Modified:
4 years ago
CC:
chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/buildtools.git@master
Target Ref:
refs/heads/master
Project:
buildtools
Visibility:
Public.

Description

Use root_out_dir for lib_dirs when building with a custom libc++. Currently, using a custom libc++ adds root_build_dir, the root of the build, to lib_dirs. When building using a non-default toolchain, this incorrectly adds the default toolchain's output directory to lib_dirs. This CL corrects this issue by adding root_out_dir, the root of the build for the current toolchain, to lib_dirs instead. BUG=573288

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/libc++/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (2 generated)
Sam McNally
4 years, 7 months ago (2016-05-17 05:37:05 UTC) #3

          

Powered by Google App Engine
This is Rietveld 408576698