Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: third_party/libc++/BUILD.gn

Issue 1984953002: Use root_out_dir for lib_dirs when building with a custom libc++. (Closed) Base URL: https://chromium.googlesource.com/chromium/buildtools.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/sanitizers/sanitizers.gni") 5 import("//build/config/sanitizers/sanitizers.gni")
6 import("//build/toolchain/toolchain.gni") 6 import("//build/toolchain/toolchain.gni")
7 7
8 # Used by libc++ and libc++abi. 8 # Used by libc++ and libc++abi.
9 config("config") { 9 config("config") {
10 defines = [ "LIBCXX_BUILDING_LIBCXXABI" ] 10 defines = [ "LIBCXX_BUILDING_LIBCXXABI" ]
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 config("link_helper") { 115 config("link_helper") {
116 ldflags = [ 116 ldflags = [
117 "-stdlib=libc++", 117 "-stdlib=libc++",
118 118
119 # Normally the generator takes care of RPATH. Our case is special because 119 # Normally the generator takes care of RPATH. Our case is special because
120 # the generator is unaware of the libc++.so dependency. Note that setting 120 # the generator is unaware of the libc++.so dependency. Note that setting
121 # RPATH here is a potential security issue. See the following for another 121 # RPATH here is a potential security issue. See the following for another
122 # example of this issue: https://code.google.com/p/gyp/issues/detail?id=315 122 # example of this issue: https://code.google.com/p/gyp/issues/detail?id=315
123 "-Wl,-R,\$ORIGIN/", 123 "-Wl,-R,\$ORIGIN/",
124 ] 124 ]
125 lib_dirs = [ root_build_dir ] 125 lib_dirs = [ root_out_dir ]
126 } 126 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698