chrome/browser/ui/sync/one_click_signin_sync_starter.cc - Issue 1984863002: Clean up LoginUIService. Remove Singleton behavior from PeopleHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/one_click_signin_sync_starter.cc

Issue 1984863002: Clean up LoginUIService. Remove Singleton behavior from PeopleHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sync and add datatype push update notifications Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/sync_global_error_unittest.cc ('k') | chrome/browser/ui/webui/options/sync_setup_handler.h » ('j') | components/browser_sync/browser/profile_sync_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/sync/one_click_signin_sync_starter.cc

diff --git a/chrome/browser/ui/sync/one_click_signin_sync_starter.cc b/chrome/browser/ui/sync/one_click_signin_sync_starter.cc

index 8aeb723f22347631056d6a4e50d7e40feea652df..dd6fa5c903535ccf67f1f573f224558f6e43fd33 100644

--- a/chrome/browser/ui/sync/one_click_signin_sync_starter.cc

+++ b/chrome/browser/ui/sync/one_click_signin_sync_starter.cc

@@ -358,7 +358,6 @@ void OneClickSigninSyncStarter::ConfirmAndSignin() {

base::UTF8ToUTF16(signin->GetUsernameForAuthInProgress()),

base::Bind(&OneClickSigninSyncStarter::UntrustedSigninConfirmed,

weak_pointer_factory_.GetWeakPtr()));

- LoginUIServiceFactory::GetForProfile(profile_)->UntrustedLoginUIShown();

} else {

// No confirmation required - just sign in the user.

signin->CompletePendingSignin();