chrome/browser/ui/webui/options/sync_setup_handler.h - Issue 1984863002: Clean up LoginUIService. Remove Singleton behavior from PeopleHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/sync_setup_handler.h

Issue 1984863002: Clean up LoginUIService. Remove Singleton behavior from PeopleHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sync and add datatype push update notifications Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/sync/one_click_signin_sync_starter.cc ('k') | chrome/browser/ui/webui/settings/people_handler.h » ('j') | components/browser_sync/browser/profile_sync_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/sync_setup_handler.h

diff --git a/chrome/browser/ui/webui/options/sync_setup_handler.h b/chrome/browser/ui/webui/options/sync_setup_handler.h

index 2ca7278e8373db9a14a9e452c92566c0fb4957b9..607173e099c2ba372eed78ca1dbe3370c6e6dc53 100644

--- a/chrome/browser/ui/webui/options/sync_setup_handler.h

+++ b/chrome/browser/ui/webui/options/sync_setup_handler.h

@@ -44,7 +44,6 @@ class SyncSetupHandler : public options::OptionsPageUIHandler,

// LoginUIService::LoginUI implementation.

void FocusUI() override;

- void CloseUI() override;

static void GetStaticLocalizedValues(

base::DictionaryValue* localized_strings,

@@ -137,6 +136,9 @@ class SyncSetupHandler : public options::OptionsPageUIHandler,

// Displays an error dialog which shows timeout of starting the sync backend.

void DisplayTimeout();

+ // Closes the associated sync settings page.

+ void CloseUI();

// Returns true if this object is the active login object.

bool IsActiveLogin() const;