Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1984733002: [Reland] GetAccountIdFromProfile() should not return an empty account id if a valid profile is prov… (Closed)

Created:
4 years, 7 months ago by xdai1
Modified:
4 years, 7 months ago
CC:
chromium-reviews, sadrul, sync-reviews_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Reland] GetAccountIdFromProfile() should not return an empty account id if a valid profile is provided. This is a reland of https://codereview.chromium.org/1880923003/. On Chrome OS, we don't end the session immediately if a refresh token is revoked in the session. Thus it's possible that we get an empty account id for a profile from Profile::GetProfileUserName(). We should avoid this scenario on Chrome OS. BUG=602807 TBR=thakis@chromium.org, rogerta@chromium.org, skuhne@chromium.org Committed: https://crrev.com/d2a0bb5307f8d0d09aff9d5d531dd9704fe85841 Cr-Commit-Position: refs/heads/master@{#392133} Committed: https://crrev.com/8a874a3155e9437511648e77acac3f8df0802de5 Cr-Commit-Position: refs/heads/master@{#393895}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -36 lines) Patch
M chrome/browser/chromeos/profiles/profile_helper.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/signin/signin_error_notifier_ash_unittest.cc View 3 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/sync/sync_error_notifier_ash_unittest.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/chrome_screenshot_grabber_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos_unittest.cc View 3 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_util.cc View 2 chunks +8 lines, -32 lines 0 comments Download
A chrome/browser/ui/ash/multi_user/multi_user_util_chromeos_unittest.cc View 1 chunk +130 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_finder_chromeos_unittest.cc View 4 chunks +16 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/signin/core/browser/fake_signin_manager.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/signin/core/browser/fake_signin_manager.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984733002/1
4 years, 7 months ago (2016-05-16 18:31:47 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-16 19:22:30 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 19:25:02 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a874a3155e9437511648e77acac3f8df0802de5
Cr-Commit-Position: refs/heads/master@{#393895}

Powered by Google App Engine
This is Rietveld 408576698