Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Unified Diff: chrome/browser/ui/browser_finder_chromeos_unittest.cc

Issue 1984733002: [Reland] GetAccountIdFromProfile() should not return an empty account id if a valid profile is prov… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_finder_chromeos_unittest.cc
diff --git a/chrome/browser/ui/browser_finder_chromeos_unittest.cc b/chrome/browser/ui/browser_finder_chromeos_unittest.cc
index d3bbb8a65d416882c902d782d0118b8f10a3c3cc..4e5bd1e7437080b74fa2b9956757bf4286df8c40 100644
--- a/chrome/browser/ui/browser_finder_chromeos_unittest.cc
+++ b/chrome/browser/ui/browser_finder_chromeos_unittest.cc
@@ -8,7 +8,9 @@
#include "ash/test/ash_test_helper.h"
#include "ash/test/test_session_state_delegate.h"
#include "base/macros.h"
+#include "chrome/browser/chromeos/login/users/scoped_user_manager_enabler.h"
#include "chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h"
+#include "chrome/browser/chromeos/profiles/profile_helper.h"
#include "chrome/browser/ui/ash/multi_user/multi_user_window_manager.h"
#include "chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.h"
#include "chrome/test/base/browser_with_test_window_test.h"
@@ -16,6 +18,8 @@
#include "chrome/test/base/testing_browser_process.h"
#include "chrome/test/base/testing_profile_manager.h"
#include "components/signin/core/account_id/account_id.h"
+#include "components/user_manager/fake_user_manager.h"
+#include "components/user_manager/user.h"
namespace test {
@@ -28,14 +32,22 @@ const char kTestAccount2[] = "user2@test.com";
class BrowserFinderChromeOSTest : public BrowserWithTestWindowTest {
protected:
- BrowserFinderChromeOSTest() : multi_user_window_manager_(nullptr) {}
+ BrowserFinderChromeOSTest()
+ : multi_user_window_manager_(nullptr),
+ fake_user_manager_(new user_manager::FakeUserManager),
+ user_manager_enabler_(fake_user_manager_) {}
TestingProfile* CreateMultiUserProfile(const AccountId& account_id) {
TestingProfile* profile =
profile_manager_->CreateTestingProfile(account_id.GetUserEmail());
- GetUserWindowManager()->AddUser(profile);
+ const user_manager::User* user = fake_user_manager_->AddUser(account_id);
+ chromeos::ProfileHelper::Get()->SetUserToProfileMappingForTesting(
+ const_cast<user_manager::User*>(user), profile);
+ chromeos::ProfileHelper::Get()->SetProfileToUserMappingForTesting(
+ const_cast<user_manager::User*>(user));
ash::test::AshTestHelper::GetTestSessionStateDelegate()->AddUser(
account_id);
+ GetUserWindowManager()->AddUser(profile);
return profile;
}
@@ -88,6 +100,8 @@ class BrowserFinderChromeOSTest : public BrowserWithTestWindowTest {
TestingProfile* second_profile_;
std::unique_ptr<TestingProfileManager> profile_manager_;
chrome::MultiUserWindowManagerChromeOS* multi_user_window_manager_;
+ user_manager::FakeUserManager* fake_user_manager_; // Not owned.
+ chromeos::ScopedUserManagerEnabler user_manager_enabler_;
DISALLOW_COPY_AND_ASSIGN(BrowserFinderChromeOSTest);
};
« no previous file with comments | « chrome/browser/ui/ash/multi_user/multi_user_util_chromeos_unittest.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698