src/global-handles.cc - Issue 19845007: wrap gc callbacks in handlescopes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/global-handles.cc

Issue 19845007: wrap gc callbacks in handlescopes (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/global-handles.cc

diff --git a/src/global-handles.cc b/src/global-handles.cc

index 5c65635d0f9f3c31f747656dee7ef4ac9bcbf20e..88ebe31647dc954fa21f0f5deca99dbf2ccc819b 100644

--- a/src/global-handles.cc

+++ b/src/global-handles.cc

@@ -262,6 +262,7 @@ class GlobalHandles::Node {

ExternalTwoByteString::cast(object_)->resource() != NULL);

// Leaving V8.

VMState<EXTERNAL> state(isolate);

+ HandleScope handle_scope(isolate);

weak_reference_callback_(reinterpret_cast<v8::Isolate*>(isolate),

reinterpret_cast<Persistent<Value>*>(&object),

par);

« no previous file with comments | « no previous file | src/heap.cc » ('j') | no next file with comments »