src/heap.cc - Issue 19845007: wrap gc callbacks in handlescopes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap.cc

Issue 19845007: wrap gc callbacks in handlescopes (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap.cc

diff --git a/src/heap.cc b/src/heap.cc

index 4a7e8f2a9af7372f229bb4828387415d5a12fe08..04aa98b2de6dfe59b3e3bc3404e674e5808d2f67 100644

--- a/src/heap.cc

+++ b/src/heap.cc

@@ -920,6 +920,7 @@ bool Heap::PerformGarbageCollection(GarbageCollector collector,

{

GCTracer::Scope scope(tracer, GCTracer::Scope::EXTERNAL);

VMState<EXTERNAL> state(isolate_);

+ HandleScope handle_scope(isolate_);

CallGCPrologueCallbacks(gc_type, kNoGCCallbackFlags);

}

@@ -1025,6 +1026,7 @@ bool Heap::PerformGarbageCollection(GarbageCollector collector,

{

GCTracer::Scope scope(tracer, GCTracer::Scope::EXTERNAL);

VMState<EXTERNAL> state(isolate_);

+ HandleScope handle_scope(isolate_);

CallGCEpilogueCallbacks(gc_type);

}

« no previous file with comments | « src/global-handles.cc ('k') | no next file » | no next file with comments »