Copy mini_installer_exe_version.rc to PRODUCT_DIR

Copy mini_installer_exe_version.rc to PRODUCT_DIR

This is needed to fix hardcoded paths in FILES.CFG that
prevent using ninja for official builds.

BUG=262193
R=grt@chromium.org, mmoss@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212719

[jschuh, 2013-07-19 20:04:35]

The issue is that FILES.cfg has a hardcoded path to
mini_installer_exe_version.rc in the intermediate directory, but ninja uses a
different intermediate structure. Ideally I would just change the destination in
this patch, but that will cause the build to break until I change the path in
FILES.cfg. So, I'm just going to copy the file in this CL, wait for a new branch
and a master restart, and then land another CL to output the file directly to
the correct location.

[jschuh, 2013-07-19 20:54:42]

@mmoss pointed out that FILES.cfg lives in the same repo and should be part of
this CL. Sorry about that, I've had too many multi-sided lands and now my brain
is broken.

Accepting that, I'm keeping this as a copy for now because the official builders
behave strangely and I've learned not to move files on them until after they've
had time to grow accustomed to the change (and @kerz will kill me if I break
them again this week).

[Michael Moss, 2013-07-19 21:04:24]

lgtm

https://codereview.chromium.org/19845002/diff/3001/chrome/installer/mini_inst...
File chrome/installer/mini_installer.gyp (right):

https://codereview.chromium.org/19845002/diff/3001/chrome/installer/mini_inst...
chrome/installer/mini_installer.gyp:151: # directly to PRODUCT_DIR when the
builders are in sync.
nit: "sync" on the builders has (unfortunately) several meanings, none of which
really make sense here. Maybe say "when the builders are verified to work with
the file only in PRODUCT_DIR", or something like that, so nobody is confused
about what this is waiting on.

[jschuh, 2013-07-19 21:43:49]

https://codereview.chromium.org/19845002/diff/3001/chrome/installer/mini_inst...
File chrome/installer/mini_installer.gyp (right):

https://codereview.chromium.org/19845002/diff/3001/chrome/installer/mini_inst...
chrome/installer/mini_installer.gyp:151: # directly to PRODUCT_DIR when the
builders are in sync.
On 2013/07/19 21:04:24, Michael Moss wrote:
> nit: "sync" on the builders has (unfortunately) several meanings, none of
which
> really make sense here. Maybe say "when the builders are verified to work with
> the file only in PRODUCT_DIR", or something like that, so nobody is confused
> about what this is waiting on.

Done.

[grt (UTC plus 2), 2013-07-19 22:29:31]

https://codereview.chromium.org/19845002/diff/17001/chrome/tools/build/win/FI...
File chrome/tools/build/win/FILES.cfg (right):

https://codereview.chromium.org/19845002/diff/17001/chrome/tools/build/win/FI...
chrome/tools/build/win/FILES.cfg:628: # Force direct archiving since the default
is to archive with path, so
does this comment and the "direct_archive" thing no longer apply?

[jschuh, 2013-07-19 22:30:40]

https://codereview.chromium.org/19845002/diff/17001/chrome/tools/build/win/FI...
File chrome/tools/build/win/FILES.cfg (right):

https://codereview.chromium.org/19845002/diff/17001/chrome/tools/build/win/FI...
chrome/tools/build/win/FILES.cfg:628: # Force direct archiving since the default
is to archive with path, so
On 2013/07/19 22:29:31, grt wrote:
> does this comment and the "direct_archive" thing no longer apply?

Ah, I guess it would not since we're moving the output path. I will remove it.

[jschuh, 2013-07-19 22:32:01]

https://codereview.chromium.org/19845002/diff/17001/chrome/tools/build/win/FI...
File chrome/tools/build/win/FILES.cfg (right):

https://codereview.chromium.org/19845002/diff/17001/chrome/tools/build/win/FI...
chrome/tools/build/win/FILES.cfg:628: # Force direct archiving since the default
is to archive with path, so
On 2013/07/19 22:30:40, Justin Schuh wrote:
> On 2013/07/19 22:29:31, grt wrote:
> > does this comment and the "direct_archive" thing no longer apply?
> 
> Ah, I guess it would not since we're moving the output path. I will remove it.

Done.

[grt (UTC plus 2), 2013-07-19 22:33:15]

lgtm

[commit-bot: I haz the power, 2013-07-19 22:37:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jschuh@chromium.org/19845002/21002

[jschuh, 2013-07-20 01:56:28]

Committed patchset #5 manually as r212719 (presubmit successful).