device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.cc - Issue 1984493002: Address property removals of GATT service and characteristic interfaces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.cc

Issue 1984493002: Address property removals of GATT service and characteristic interfaces (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/bluetooth/bluez/bluetooth_gatt_bluez_unittest.cc ('k') | device/bluetooth/dbus/bluetooth_gatt_characteristic_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.cc

diff --git a/device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.cc b/device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.cc

index d409a34f67f861afe4836b48b5650bea3cb11f43..60313881991a1fb33d086d5931dbecc2a1e56312 100644

--- a/device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.cc

+++ b/device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.cc

@@ -165,19 +165,7 @@ void BluetoothRemoteGattServiceBlueZ::GattServicePropertyChanged(

->GetProperties(object_path);

DCHECK(properties);

- if (property_name != properties->characteristics.name()) {

- NotifyServiceChanged();

- return;

- }

- if (discovery_complete_)

- return;

- VLOG(1) << "All characteristics were discovered for service: "

- << object_path.value();

- discovery_complete_ = true;

- DCHECK(GetAdapter());

- GetAdapter()->NotifyGattDiscoveryComplete(this);

+ NotifyServiceChanged();

}

void BluetoothRemoteGattServiceBlueZ::GattCharacteristicAdded(