Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8494)

Unified Diff: device/bluetooth/bluez/bluetooth_gatt_bluez_unittest.cc

Issue 1984493002: Address property removals of GATT service and characteristic interfaces (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/bluetooth/bluez/bluetooth_gatt_bluez_unittest.cc
diff --git a/device/bluetooth/bluez/bluetooth_gatt_bluez_unittest.cc b/device/bluetooth/bluez/bluetooth_gatt_bluez_unittest.cc
index e2cc16a2b1b76f8e74d5817e188acab0ceb08da3..ce7087eac54dbcbd2531be33b5e3c23f228bd4ac 100644
--- a/device/bluetooth/bluez/bluetooth_gatt_bluez_unittest.cc
+++ b/device/bluetooth/bluez/bluetooth_gatt_bluez_unittest.cc
@@ -450,7 +450,6 @@ TEST_F(BluetoothGattBlueZTest, GattCharacteristicAddedAndRemoved) {
// value changed signals. Service changed should be fired once for
// descriptor added.
EXPECT_EQ(0, observer.gatt_service_changed_count());
- EXPECT_EQ(1, observer.gatt_discovery_complete_count());
EXPECT_EQ(3, observer.gatt_characteristic_added_count());
EXPECT_EQ(0, observer.gatt_characteristic_removed_count());
EXPECT_EQ(0, observer.gatt_characteristic_value_changed_count());
@@ -471,7 +470,6 @@ TEST_F(BluetoothGattBlueZTest, GattCharacteristicAddedAndRemoved) {
fake_bluetooth_gatt_characteristic_client_->ExposeHeartRateCharacteristics(
fake_bluetooth_gatt_service_client_->GetHeartRateServicePath());
EXPECT_EQ(0, observer.gatt_service_changed_count());
- EXPECT_EQ(1, observer.gatt_discovery_complete_count());
EXPECT_EQ(6, observer.gatt_characteristic_added_count());
EXPECT_EQ(3, observer.gatt_characteristic_removed_count());
EXPECT_EQ(0, observer.gatt_characteristic_value_changed_count());
@@ -927,14 +925,12 @@ TEST_F(BluetoothGattBlueZTest, GattDescriptorValue) {
device->GetGattService(observer.last_gatt_service_id());
EXPECT_EQ(0, observer.gatt_service_changed_count());
- EXPECT_EQ(0, observer.gatt_discovery_complete_count());
EXPECT_EQ(0, observer.gatt_descriptor_value_changed_count());
EXPECT_TRUE(service->GetCharacteristics().empty());
// Run the message loop so that the characteristics appear.
base::MessageLoop::current()->Run();
EXPECT_EQ(0, observer.gatt_service_changed_count());
- EXPECT_EQ(1, observer.gatt_discovery_complete_count());
// Only the Heart Rate Measurement characteristic has a descriptor.
BluetoothRemoteGattCharacteristic* characteristic =
« no previous file with comments | « no previous file | device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698