Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1984353003: Update DataReductionProxy page load metrics to log immediately. (Closed)

Created:
4 years, 7 months ago by Bryan McQuade
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update DataReductionProxy page load metrics to log immediately. BUG=612561 Committed: https://crrev.com/966b88a52931372065b63b8190379ee396ae0c9a Cr-Commit-Position: refs/heads/master@{#394579}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -19 lines) Patch
M chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc View 2 chunks +3 lines, -11 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Bryan McQuade
PTAL. Ben and Ryan, I sent an email to you earlier with some additional context.
4 years, 7 months ago (2016-05-17 19:48:28 UTC) #2
RyanSturm
On 2016/05/17 19:48:28, Bryan McQuade wrote: > PTAL. Ben and Ryan, I sent an email ...
4 years, 7 months ago (2016-05-17 19:52:57 UTC) #3
Bryan McQuade
On 2016/05/17 at 19:52:57, ryansturm wrote: > On 2016/05/17 19:48:28, Bryan McQuade wrote: > > ...
4 years, 7 months ago (2016-05-17 20:04:38 UTC) #4
Charlie Harrison
lgtm
4 years, 7 months ago (2016-05-17 20:05:26 UTC) #5
bengr
lgtm
4 years, 7 months ago (2016-05-17 20:18:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984353003/1
4 years, 7 months ago (2016-05-18 20:02:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 22:43:05 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 22:44:16 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/966b88a52931372065b63b8190379ee396ae0c9a
Cr-Commit-Position: refs/heads/master@{#394579}

Powered by Google App Engine
This is Rietveld 408576698