Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc

Issue 1984353003: Update DataReductionProxy page load metrics to log immediately. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc
index 59f20449bc8eb58628c03d7d8e8b55d18b2ac122..11d251e1a76f6a4d9be027314d26166e9c39b42f 100644
--- a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc
@@ -18,10 +18,10 @@ namespace data_reduction_proxy {
namespace internal {
const char kHistogramFirstContentfulPaintDataReductionProxy[] =
- "PageLoad.Clients.DataReductionProxy.Timing2."
+ "PageLoad.Clients.DataReductionProxy.PaintTiming."
"NavigationToFirstContentfulPaint";
const char kHistogramFirstContentfulPaintDataReductionProxyLoFiOn[] =
- "PageLoad.Clients.DataReductionProxy.LoFiOn.Timing2."
+ "PageLoad.Clients.DataReductionProxy.LoFiOn.PaintTiming."
"NavigationToFirstContentfulPaint";
} // namespace internal
@@ -52,17 +52,9 @@ void DataReductionProxyMetricsObserver::OnCommit(
lofi_requested_ = data->lofi_requested();
}
-void DataReductionProxyMetricsObserver::OnComplete(
+void DataReductionProxyMetricsObserver::OnFirstContentfulPaint(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) {
- RecordTimingHistograms(timing, info);
-}
-
-// Record first contentful paint UMA for various DataReductionProxy
-// configurations.
-void DataReductionProxyMetricsObserver::RecordTimingHistograms(
- const page_load_metrics::PageLoadTiming& timing,
- const page_load_metrics::PageLoadExtraInfo& info) const {
if (!used_data_reduction_proxy_ ||
!WasStartedInForegroundEventInForeground(timing.first_contentful_paint,
info))

Powered by Google App Engine
This is Rietveld 408576698