Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: pkg/analyzer_cli/test/sdk_ext_test.dart

Issue 1984323004: Test exit code handling fix [TBR]. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer_cli/test/sdk_ext_test.dart
diff --git a/pkg/analyzer_cli/test/sdk_ext_test.dart b/pkg/analyzer_cli/test/sdk_ext_test.dart
index 42e3fa5ec8bcb3772dc927b85c44243bedd3cb91..cddc7ae5d55b3531c0747356c8495f42b4e076bf 100644
--- a/pkg/analyzer_cli/test/sdk_ext_test.dart
+++ b/pkg/analyzer_cli/test/sdk_ext_test.dart
@@ -9,6 +9,7 @@ import 'dart:io';
import 'package:analyzer/src/generated/sdk_io.dart';
import 'package:analyzer_cli/src/driver.dart' show Driver, errorSink, outSink;
+import 'package:analyzer_cli/src/options.dart';
import 'package:path/path.dart' as path;
import 'package:unittest/unittest.dart';
@@ -18,11 +19,14 @@ main() {
group('Sdk extensions', () {
StringSink savedOutSink, savedErrorSink;
int savedExitCode;
+ ExitHandler savedExitHandler;
setUp(() {
savedOutSink = outSink;
savedErrorSink = errorSink;
+ savedExitHandler = exitHandler;
savedExitCode = exitCode;
+ exitHandler = (code) => exitCode = code;
outSink = new StringBuffer();
errorSink = new StringBuffer();
});
@@ -30,15 +34,17 @@ main() {
outSink = savedOutSink;
errorSink = savedErrorSink;
exitCode = savedExitCode;
+ exitHandler = savedExitHandler;
});
test('.packages file present', () async {
String testDir = path.join(testDirectory, 'data', 'packages_file');
- Driver driver = new Driver()..start([
- '--packages',
- path.join(testDir, '.packages'),
- path.join(testDir, 'sdk_ext_user.dart')
- ]);
+ Driver driver = new Driver()
+ ..start([
+ '--packages',
+ path.join(testDir, '.packages'),
+ path.join(testDir, 'sdk_ext_user.dart')
+ ]);
DirectoryBasedDartSdk sdk = driver.sdk;
expect(sdk.useSummary, isFalse);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698