Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Side by Side Diff: pkg/analyzer_cli/test/sdk_ext_test.dart

Issue 1984323004: Test exit code handling fix [TBR]. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /// Test that sdk extensions are properly detected in various scenarios. 5 /// Test that sdk extensions are properly detected in various scenarios.
6 library analyzer_cli.test.sdk_ext; 6 library analyzer_cli.test.sdk_ext;
7 7
8 import 'dart:io'; 8 import 'dart:io';
9 9
10 import 'package:analyzer/src/generated/sdk_io.dart'; 10 import 'package:analyzer/src/generated/sdk_io.dart';
11 import 'package:analyzer_cli/src/driver.dart' show Driver, errorSink, outSink; 11 import 'package:analyzer_cli/src/driver.dart' show Driver, errorSink, outSink;
12 import 'package:analyzer_cli/src/options.dart';
12 import 'package:path/path.dart' as path; 13 import 'package:path/path.dart' as path;
13 import 'package:unittest/unittest.dart'; 14 import 'package:unittest/unittest.dart';
14 15
15 import 'utils.dart'; 16 import 'utils.dart';
16 17
17 main() { 18 main() {
18 group('Sdk extensions', () { 19 group('Sdk extensions', () {
19 StringSink savedOutSink, savedErrorSink; 20 StringSink savedOutSink, savedErrorSink;
20 int savedExitCode; 21 int savedExitCode;
22 ExitHandler savedExitHandler;
21 23
22 setUp(() { 24 setUp(() {
23 savedOutSink = outSink; 25 savedOutSink = outSink;
24 savedErrorSink = errorSink; 26 savedErrorSink = errorSink;
27 savedExitHandler = exitHandler;
25 savedExitCode = exitCode; 28 savedExitCode = exitCode;
29 exitHandler = (code) => exitCode = code;
26 outSink = new StringBuffer(); 30 outSink = new StringBuffer();
27 errorSink = new StringBuffer(); 31 errorSink = new StringBuffer();
28 }); 32 });
29 tearDown(() { 33 tearDown(() {
30 outSink = savedOutSink; 34 outSink = savedOutSink;
31 errorSink = savedErrorSink; 35 errorSink = savedErrorSink;
32 exitCode = savedExitCode; 36 exitCode = savedExitCode;
37 exitHandler = savedExitHandler;
33 }); 38 });
34 39
35 test('.packages file present', () async { 40 test('.packages file present', () async {
36 String testDir = path.join(testDirectory, 'data', 'packages_file'); 41 String testDir = path.join(testDirectory, 'data', 'packages_file');
37 Driver driver = new Driver()..start([ 42 Driver driver = new Driver()
38 '--packages', 43 ..start([
39 path.join(testDir, '.packages'), 44 '--packages',
40 path.join(testDir, 'sdk_ext_user.dart') 45 path.join(testDir, '.packages'),
41 ]); 46 path.join(testDir, 'sdk_ext_user.dart')
47 ]);
42 48
43 DirectoryBasedDartSdk sdk = driver.sdk; 49 DirectoryBasedDartSdk sdk = driver.sdk;
44 expect(sdk.useSummary, isFalse); 50 expect(sdk.useSummary, isFalse);
45 51
46 expect(exitCode, 0); 52 expect(exitCode, 0);
47 }); 53 });
48 }); 54 });
49 } 55 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698