Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 1984163002: Fix up CSSStyleDeclaration::cssText serialization (Closed)

Created:
4 years, 7 months ago by Timothy Loh
Modified:
4 years, 7 months ago
CC:
darktears, Andy Mutton, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, dglazkov+blink, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, rwlbuis, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@border
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix up CSSStyleDeclaration::cssText serialization This patch fixes up CSSStyleDeclaration::cssText serialization in several ways: - Removes switch statement and just defers to getPropertyValue. This will allow us to move generic checks (e.g. for initial) up so individual shorthand serialization routines don't need to handle it. - Supports all shorthands (except font) now. This adds support for marker, columns, column-rule, font-variant, -webkit-margin-collapse, -webkit-mask-repeat, -webkit-text-stroke. - Support serialization as border-top/bottom/left/right. Currently we only use border and border-width/color/style. As per CSSOM, we prefer (e.g.) border-width to border-top as it has more longhands. - Avoid serializing border-image when border is serialized as border-image is a reset-only sub-property (but border serialization still fails to require border-image to be correctly set). https://www.w3.org/TR/cssom-1/#concept-shorthands-preferred-order BUG=612363 Committed: https://crrev.com/ee9bb4bbcd3eecff24fc8d11b21147e8a3b0c5df Cr-Commit-Position: refs/heads/master@{#394653}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages

Total messages: 11 (6 generated)
Timothy Loh
4 years, 7 months ago (2016-05-17 06:44:25 UTC) #3
alancutter (OOO until 2018)
lgtm
4 years, 7 months ago (2016-05-18 07:27:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984163002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984163002/60001
4 years, 7 months ago (2016-05-19 01:25:07 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-19 03:32:52 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 03:34:28 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ee9bb4bbcd3eecff24fc8d11b21147e8a3b0c5df
Cr-Commit-Position: refs/heads/master@{#394653}

Powered by Google App Engine
This is Rietveld 408576698