third_party/WebKit/Source/build/scripts/make_style_shorthands.py - Issue 1984163002: Fix up CSSStyleDeclaration::cssText serialization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/make_style_shorthands.py

Issue 1984163002: Fix up CSSStyleDeclaration::cssText serialization (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@border

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/build/scripts/make_style_shorthands.py

diff --git a/third_party/WebKit/Source/build/scripts/make_style_shorthands.py b/third_party/WebKit/Source/build/scripts/make_style_shorthands.py

index 46d7fc78b82df05d481f68ba69749531bcc689d0..db13d4791b9940253c4e1ab48c541d1d9a7c6b53 100755

--- a/third_party/WebKit/Source/build/scripts/make_style_shorthands.py

+++ b/third_party/WebKit/Source/build/scripts/make_style_shorthands.py

@@ -54,6 +54,11 @@ class StylePropertyShorthandWriter(css_properties.CSSProperties):

property['longhand_property_ids'] = map(enum_for_css_property, property['longhands'].split(';'))

for longhand in property['longhand_property_ids']:

self._longhand_dictionary[longhand].append(property)

+ for longhands in self._longhand_dictionary.values():

+ # Sort first by number of longhands in decreasing order, then alphabetically

+ longhands.sort(

+ key=lambda property: (-len(property['longhand_property_ids']), property['name'])

+ )

@template_expander.use_jinja('StylePropertyShorthand.cpp.tmpl')

def generate_style_property_shorthand_cpp(self):