chrome/browser/ui/views/frame/browser_view.cc - Issue 198413003: Enable immersive fullscreen on Windows Ash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 198413003: Enable immersive fullscreen on Windows Ash. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix some linux compile errors, and check USE_ASH instead of OS define. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index 140fc59fc475da954a5fa6eb1270ebd459b7c287..552b08cd2e5861dfa4a6f3286da35d10a2316001 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -2244,6 +2244,9 @@ bool BrowserView::ShouldUseImmersiveFullscreenForUrl(const GURL& url) const {

// Kiosk mode needs the whole screen.

if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kKioskMode))

return false;

+#endif

+#if defined(USE_ASH)

pkotwicz 2014/03/13 18:34:32 What was the result of your investigation into whe

zturner 2014/03/13 19:28:10 Didn't get to it yet, but doing so after I upload

bool is_browser_fullscreen = url.is_empty();

if (ash::switches::UseImmersiveFullscreenForAllWindows())

return is_browser_fullscreen;