Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Side by Side Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 198413003: Enable immersive fullscreen on Windows Ash. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix some linux compile errors, and check USE_ASH instead of OS define. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/frame/browser_view.h" 5 #include "chrome/browser/ui/views/frame/browser_view.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/auto_reset.h" 9 #include "base/auto_reset.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 2226 matching lines...) Expand 10 before | Expand all | Expand 10 after
2237 // order to let the layout occur. 2237 // order to let the layout occur.
2238 in_process_fullscreen_ = false; 2238 in_process_fullscreen_ = false;
2239 ToolbarSizeChanged(false); 2239 ToolbarSizeChanged(false);
2240 } 2240 }
2241 2241
2242 bool BrowserView::ShouldUseImmersiveFullscreenForUrl(const GURL& url) const { 2242 bool BrowserView::ShouldUseImmersiveFullscreenForUrl(const GURL& url) const {
2243 #if defined(OS_CHROMEOS) 2243 #if defined(OS_CHROMEOS)
2244 // Kiosk mode needs the whole screen. 2244 // Kiosk mode needs the whole screen.
2245 if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kKioskMode)) 2245 if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kKioskMode))
2246 return false; 2246 return false;
2247 #endif
2248
2249 #if defined(USE_ASH)
pkotwicz 2014/03/13 18:34:32 What was the result of your investigation into whe
zturner 2014/03/13 19:28:10 Didn't get to it yet, but doing so after I upload
2247 bool is_browser_fullscreen = url.is_empty(); 2250 bool is_browser_fullscreen = url.is_empty();
2248 if (ash::switches::UseImmersiveFullscreenForAllWindows()) 2251 if (ash::switches::UseImmersiveFullscreenForAllWindows())
2249 return is_browser_fullscreen; 2252 return is_browser_fullscreen;
2250 else 2253 else
2251 return is_browser_fullscreen && IsBrowserTypeNormal(); 2254 return is_browser_fullscreen && IsBrowserTypeNormal();
2252 #else 2255 #else
2253 return false; 2256 return false;
2254 #endif 2257 #endif
2255 } 2258 }
2256 2259
(...skipping 320 matching lines...) Expand 10 before | Expand all | Expand 10 after
2577 !GetLocationBar()->GetOmniboxView()->model()->popup_model()->IsOpen()) { 2580 !GetLocationBar()->GetOmniboxView()->model()->popup_model()->IsOpen()) {
2578 gfx::Point icon_bottom( 2581 gfx::Point icon_bottom(
2579 toolbar_->location_bar()->GetLocationBarAnchorPoint()); 2582 toolbar_->location_bar()->GetLocationBarAnchorPoint());
2580 ConvertPointToTarget(toolbar_->location_bar(), this, &icon_bottom); 2583 ConvertPointToTarget(toolbar_->location_bar(), this, &icon_bottom);
2581 gfx::Point infobar_top(0, infobar_container_->GetVerticalOverlap(NULL)); 2584 gfx::Point infobar_top(0, infobar_container_->GetVerticalOverlap(NULL));
2582 ConvertPointToTarget(infobar_container_, this, &infobar_top); 2585 ConvertPointToTarget(infobar_container_, this, &infobar_top);
2583 top_arrow_height = infobar_top.y() - icon_bottom.y(); 2586 top_arrow_height = infobar_top.y() - icon_bottom.y();
2584 } 2587 }
2585 return top_arrow_height; 2588 return top_arrow_height;
2586 } 2589 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698