Enable immersive fullscreen on Windows Ash.

chrome/browser/ui/views/frame/immersive_mode_controller_factory.cc

Index: chrome/browser/ui/views/frame/immersive_mode_controller_factory.cc
diff --git a/chrome/browser/ui/views/frame/immersive_mode_controller_factory.cc b/chrome/browser/ui/views/frame/immersive_mode_controller_factory.cc
index ad89c60553b823994f018526b81baa63397c81ea..bf41ff28035cd6722fa92eb3b95e8b084e7b6b8a 100644
--- a/chrome/browser/ui/views/frame/immersive_mode_controller_factory.cc
+++ b/chrome/browser/ui/views/frame/immersive_mode_controller_factory.cc
@@ -3,21 +3,12 @@
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/immersive_mode_controller.h"
-
-#include "chrome/browser/ui/views/frame/immersive_mode_controller_stub.h"
-
-#if defined(OS_CHROMEOS)
 #include "chrome/browser/ui/views/frame/immersive_mode_controller_ash.h"
-#endif  // defined(OS_CHROMEOS)
 
 namespace chrome {
 
 ImmersiveModeController* CreateImmersiveModeController() {
-#if defined(OS_CHROMEOS)

[pkotwicz, 2014/03/13 16:48:19]

The new ifdef should be:
#if defined(USE_ASH)

Linux Aura does not use ash. It is possible that we will change the ifdef once
it does

[zturner, 2014/03/13 16:54:06]

I assume the same applies everywhere that there used to be an #if
defined(OS_CHROMEOS)?  There was one place talking about kiosk mode, but I think
that's still CrOS only, right?

So just to be clear, compiling on Linux with USE_ASH currently isn't supported
anyway, so right now USE_ASH is equivalent to OS_CHROMEOS || OS_WIN?

[pkotwicz, 2014/03/13 18:08:45]

That is correct. You can remove the ifdef completely in files under ash/ though.

   return new ImmersiveModeControllerAsh();
-#else
-  return new ImmersiveModeControllerStub();
-#endif
 }

[pkotwicz, 2014/03/13 16:48:19]

Can you reenable immersive_mode_controller_ash_unittest.cc on Windows and make
sure that the test works properly?

You'll probably also need to update accelerator_commands_browsertest.cc

[zturner, 2014/03/13 16:54:06]

Thanks, I missed these.

[zturner, 2014/03/13 17:56:39]

All of these tests are broken because of this:

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/base/b...

LMK if you think this needs to be fixed before submitting this, or if it can be
fixed as a followup.

 
 }  // namespace chrome