chrome/browser/ui/views/frame/immersive_mode_controller_factory.cc - Issue 198413003: Enable immersive fullscreen on Windows Ash.

Side by Side Diff: chrome/browser/ui/views/frame/immersive_mode_controller_factory.cc

Issue 198413003: Enable immersive fullscreen on Windows Ash. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/views/frame/immersive_mode_controller.h"	5 #include "chrome/browser/ui/views/frame/immersive_mode_controller.h"

6

7 #include "chrome/browser/ui/views/frame/immersive_mode_controller_stub.h"

8

9 #if defined(OS_CHROMEOS)

10 #include "chrome/browser/ui/views/frame/immersive_mode_controller_ash.h"	6 #include "chrome/browser/ui/views/frame/immersive_mode_controller_ash.h"

11 #endif // defined(OS_CHROMEOS)

12	7

13 namespace chrome {	8 namespace chrome {

14	9

15 ImmersiveModeController* CreateImmersiveModeController() {	10 ImmersiveModeController* CreateImmersiveModeController() {

16 #if defined(OS_CHROMEOS)
pkotwicz 2014/03/13 16:48:19 The new ifdef should be: #if defined(USE_ASH) Lin The new ifdef should be: #if defined(USE_ASH) Linux Aura does not use ash. It is possible that we will change the ifdef once it does zturner 2014/03/13 16:54:06 I assume the same applies everywhere that there us Show quoted text On 2014/03/13 16:48:19, pkotwicz wrote: > The new ifdef should be: > #if defined(USE_ASH) > > Linux Aura does not use ash. It is possible that we will change the ifdef once > it does > I assume the same applies everywhere that there used to be an #if defined(OS_CHROMEOS)? There was one place talking about kiosk mode, but I think that's still CrOS only, right? So just to be clear, compiling on Linux with USE_ASH currently isn't supported anyway, so right now USE_ASH is equivalent to OS_CHROMEOS \|\| OS_WIN? pkotwicz 2014/03/13 18:08:45 That is correct. You can remove the ifdef complete That is correct. You can remove the ifdef completely in files under ash/ though.
17 return new ImmersiveModeControllerAsh();	11 return new ImmersiveModeControllerAsh();

18 #else

19 return new ImmersiveModeControllerStub();

20 #endif

21 }	12 }
pkotwicz 2014/03/13 16:48:19 Can you reenable immersive_mode_controller_ash_uni Can you reenable immersive_mode_controller_ash_unittest.cc on Windows and make sure that the test works properly? You'll probably also need to update accelerator_commands_browsertest.cc zturner 2014/03/13 16:54:06 Thanks, I missed these. Show quoted text On 2014/03/13 16:48:19, pkotwicz wrote: > Can you reenable immersive_mode_controller_ash_unittest.cc on Windows and make > sure that the test works properly? > > You'll probably also need to update accelerator_commands_browsertest.cc Thanks, I missed these. zturner 2014/03/13 17:56:39 All of these tests are broken because of this: ht Show quoted text On 2014/03/13 16:48:19, pkotwicz wrote: > Can you reenable immersive_mode_controller_ash_unittest.cc on Windows and make > sure that the test works properly? > > You'll probably also need to update accelerator_commands_browsertest.cc All of these tests are broken because of this: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/base/b... LMK if you think this needs to be fixed before submitting this, or if it can be fixed as a followup.
22	13

23 } // namespace chrome	14 } // namespace chrome

OLD	NEW