content_shell: Redirect resource requests for some local paths.

content_shell: Redirect resource requests for some local paths.

This CL changes content_shell in layout test mode so that it redirects resource
requests for file:///{common,images,media,resources}/ to third_party/WebKit/
LayoutTests/imported/wpt/*.

Such URLs are resolved from absolute path links in web-platform-tests like
<script src="/resources/testharness.js">.

After this CL, we can remove path rewrite step for /resources and /common in
test_converter.py.

BUG=498120, 613408
Committed: https://crrev.com/3f67002a393008c12f36c27ce46e38ea3ee9e0c9
Cr-Commit-Position: refs/heads/master@{#395025}

[tkent, 2016-05-17 02:23:18]

Patchset #1 (id:1) has been deleted

[tkent, 2016-05-17 02:27:41]

Description was changed from

==========
content_shell: Redirect resource requests for some local paths.

This CL changes content_shell in layout test mode so that it redirects resource
requests for file: outside of third_party/WebKit/LayoutTests/ to
third_party/WebKit/LayoutTests/imported/wpt/.

Such URLs are resolved from absolute path links in web-platform-tests such as
<script src="/resources/testharness.js">.

After this CL and reimporting WPT, imported WPT tests won't work with real
browsers.

BUG=
==========

to

==========
content_shell: Redirect resource requests for some local paths.

This CL changes content_shell in layout test mode so that it redirects resource
requests for file: outside of third_party/WebKit/LayoutTests/ to
third_party/WebKit/LayoutTests/imported/wpt/.

Such URLs are resolved from absolute path links in web-platform-tests like
<script src="/resources/testharness.js">.

BUG=
==========

[tkent, 2016-05-17 02:33:23]

Description was changed from

==========
content_shell: Redirect resource requests for some local paths.

This CL changes content_shell in layout test mode so that it redirects resource
requests for file: outside of third_party/WebKit/LayoutTests/ to
third_party/WebKit/LayoutTests/imported/wpt/.

Such URLs are resolved from absolute path links in web-platform-tests like
<script src="/resources/testharness.js">.

BUG=
==========

to

==========
content_shell: Redirect resource requests for some local paths.

This CL changes content_shell in layout test mode so that it redirects resource
requests for file: outside of third_party/WebKit/LayoutTests/ to
third_party/WebKit/LayoutTests/imported/wpt/.

Such URLs are resolved from absolute path links in web-platform-tests like
<script src="/resources/testharness.js">.

BUG=498120
==========

[tkent, 2016-05-17 03:34:24]

Patchset #1 (id:20001) has been deleted

[tkent, 2016-05-17 03:34:28]

Patchset #1 (id:40001) has been deleted

[tkent, 2016-05-18 04:32:58]

Patchset #1 (id:60001) has been deleted

[tkent, 2016-05-18 04:33:03]

Patchset #1 (id:80001) has been deleted

[tkent, 2016-05-18 04:33:07]

Patchset #1 (id:100001) has been deleted

[tkent, 2016-05-18 04:33:11]

Patchset #1 (id:120001) has been deleted

[tkent, 2016-05-18 06:43:47]

Description was changed from

==========
content_shell: Redirect resource requests for some local paths.

This CL changes content_shell in layout test mode so that it redirects resource
requests for file: outside of third_party/WebKit/LayoutTests/ to
third_party/WebKit/LayoutTests/imported/wpt/.

Such URLs are resolved from absolute path links in web-platform-tests like
<script src="/resources/testharness.js">.

BUG=498120
==========

to

==========
content_shell: Redirect resource requests for some local paths.

This CL changes content_shell in layout test mode so that it redirects resource
requests for file:///{common,images,media,resources}/ to third_party/WebKit/
LayoutTests/imported/wpt/*.

Such URLs are resolved from absolute path links in web-platform-tests like
<script src="/resources/testharness.js">.

After this CL, we can remove path rewrite step for /resources and /common in
test_converter.py.

BUG=498120
==========

[tkent, 2016-05-18 07:32:54]

tkent@chromium.org changed reviewers:
+ jsbell@chromium.org, qyearsley@chromium.org

[tkent, 2016-05-18 07:32:54]

jsbell@, qyearsley@, do you think we should proceed this CL?

note: autocapitalize.html is just a demonstration.  I'll revert it if we proceed
this approach.

[tkent, 2016-05-18 08:22:53]

Patchset #1 (id:140001) has been deleted

[jsbell, 2016-05-18 17:20:26]

lgtm

[qyearsley, 2016-05-18 17:26:56]

https://codereview.chromium.org/1984103003/diff/160001/content/shell/renderer...
File content/shell/renderer/layout_test/blink_test_runner.cc (right):

https://codereview.chromium.org/1984103003/diff/160001/content/shell/renderer...
content/shell/renderer/layout_test/blink_test_runner.cc:207: WebURL
RewriteAbsolutePathInWPT(const std::string& utf8_url) {
The main reason for this is so that we don't have to modify the imported web
platform tests, right?

Maybe we could add a comment somewhere here noting this?

https://codereview.chromium.org/1984103003/diff/160001/content/shell/renderer...
content/shell/renderer/layout_test/blink_test_runner.cc:228: // a short-teram
workaround. We can remove this hack when we start to run
short-term

https://codereview.chromium.org/1984103003/diff/160001/content/shell/renderer...
content/shell/renderer/layout_test/blink_test_runner.cc:229: // all WPT tests
with wptserve.
Although, we may want to still want to have most tests run using file:// even if
when wptserve is used for the tests that require it; in that case, we may want
to keep this path rewriting in place.

https://codereview.chromium.org/1984103003/diff/160001/content/shell/renderer...
content/shell/renderer/layout_test/blink_test_runner.cc:351: WebURL url =
RewriteAbsolutePathInWPT(utf8_url);
Would rewritten_url make sense for this variable name? Keeping it as url is also
fine if that seems better to you.

[tkent, 2016-05-20 00:59:21]

Patchset #2 (id:180001) has been deleted

[tkent, 2016-05-20 01:00:30]

https://codereview.chromium.org/1984103003/diff/160001/content/shell/renderer...
File content/shell/renderer/layout_test/blink_test_runner.cc (right):

https://codereview.chromium.org/1984103003/diff/160001/content/shell/renderer...
content/shell/renderer/layout_test/blink_test_runner.cc:207: WebURL
RewriteAbsolutePathInWPT(const std::string& utf8_url) {
On 2016/05/18 at 17:26:56, qyearsley wrote:
> The main reason for this is so that we don't have to modify the imported web
platform tests, right?
> 
> Maybe we could add a comment somewhere here noting this?

Done.

https://codereview.chromium.org/1984103003/diff/160001/content/shell/renderer...
content/shell/renderer/layout_test/blink_test_runner.cc:228: // a short-teram
workaround. We can remove this hack when we start to run
On 2016/05/18 at 17:26:56, qyearsley wrote:
> short-term

Removed.

https://codereview.chromium.org/1984103003/diff/160001/content/shell/renderer...
content/shell/renderer/layout_test/blink_test_runner.cc:229: // all WPT tests
with wptserve.
On 2016/05/18 at 17:26:56, qyearsley wrote:
> Although, we may want to still want to have most tests run using file:// even
if when wptserve is used for the tests that require it; in that case, we may
want to keep this path rewriting in place.

I updated the comment.

https://codereview.chromium.org/1984103003/diff/160001/content/shell/renderer...
content/shell/renderer/layout_test/blink_test_runner.cc:351: WebURL url =
RewriteAbsolutePathInWPT(utf8_url);
On 2016/05/18 at 17:26:56, qyearsley wrote:
> Would rewritten_url make sense for this variable name? Keeping it as url is
also fine if that seems better to you.

Done.

[tkent, 2016-05-20 01:05:01]

Description was changed from

==========
content_shell: Redirect resource requests for some local paths.

This CL changes content_shell in layout test mode so that it redirects resource
requests for file:///{common,images,media,resources}/ to third_party/WebKit/
LayoutTests/imported/wpt/*.

Such URLs are resolved from absolute path links in web-platform-tests like
<script src="/resources/testharness.js">.

After this CL, we can remove path rewrite step for /resources and /common in
test_converter.py.

BUG=498120
==========

to

==========
content_shell: Redirect resource requests for some local paths.

This CL changes content_shell in layout test mode so that it redirects resource
requests for file:///{common,images,media,resources}/ to third_party/WebKit/
LayoutTests/imported/wpt/*.

Such URLs are resolved from absolute path links in web-platform-tests like
<script src="/resources/testharness.js">.

After this CL, we can remove path rewrite step for /resources and /common in
test_converter.py.

BUG=498120, 613408
==========

[tkent, 2016-05-20 01:05:43]

tkent@chromium.org changed reviewers:
+ kinuko@chromium.org

[tkent, 2016-05-20 01:05:44]

kinuko-san, would you approve this please?

[kinuko, 2016-05-20 01:44:14]

lgtm.

[tkent, 2016-05-20 07:12:16]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-05-20 07:12:17]

The patchset sent to the CQ was uploaded after l-g-t-m from jsbell@chromium.org
Link to the patchset: https://codereview.chromium.org/1984103003/#ps200001
(title: "Apply review comments")

[commit-bot: I haz the power, 2016-05-20 07:12:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1984103003/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1984103003/200001

[commit-bot: I haz the power, 2016-05-20 07:16:05]

Committed patchset #2 (id:200001)

[commit-bot: I haz the power, 2016-05-20 07:17:27]

Description was changed from

==========
content_shell: Redirect resource requests for some local paths.

This CL changes content_shell in layout test mode so that it redirects resource
requests for file:///{common,images,media,resources}/ to third_party/WebKit/
LayoutTests/imported/wpt/*.

Such URLs are resolved from absolute path links in web-platform-tests like
<script src="/resources/testharness.js">.

After this CL, we can remove path rewrite step for /resources and /common in
test_converter.py.

BUG=498120, 613408
==========

to

==========
content_shell: Redirect resource requests for some local paths.

This CL changes content_shell in layout test mode so that it redirects resource
requests for file:///{common,images,media,resources}/ to third_party/WebKit/
LayoutTests/imported/wpt/*.

Such URLs are resolved from absolute path links in web-platform-tests like
<script src="/resources/testharness.js">.

After this CL, we can remove path rewrite step for /resources and /common in
test_converter.py.

BUG=498120, 613408

Committed: https://crrev.com/3f67002a393008c12f36c27ce46e38ea3ee9e0c9
Cr-Commit-Position: refs/heads/master@{#395025}
==========

[commit-bot: I haz the power, 2016-05-20 07:17:29]

Patchset 2 (id:??) landed as
https://crrev.com/3f67002a393008c12f36c27ce46e38ea3ee9e0c9
Cr-Commit-Position: refs/heads/master@{#395025}