content_shell: Redirect resource requests for some local paths.

content/shell/renderer/layout_test/blink_test_runner.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/shell/renderer/layout_test/blink_test_runner.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <clocale>
 #include <cmath>
 #include <memory>
 #include <utility>
 
 #include "base/base64.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/debug/debugger.h"
 #include "base/files/file_path.h"
+#include "base/files/file_util.h"
 #include "base/location.h"
 #include "base/macros.h"
 #include "base/md5.h"
 #include "base/memory/ptr_util.h"
 #include "base/single_thread_task_runner.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/threading/thread_task_runner_handle.h"
@@ skipping 166 matching lines @@
                   int session_id) override {}
   void Start() override {}
   void Stop() override {}
   void SetVolume(double volume) override {}
   void SetAutomaticGainControl(bool enable) override {}
 
  protected:
   ~MockAudioCapturerSource() override {}
 };
 
+WebURL RewriteAbsolutePathInWPT(const std::string& utf8_url) {

[qyearsley, 2016/05/18 17:26:56]

The main reason for this is so that we don't have to modify the imported web
platform tests, right?

Maybe we could add a comment somewhere here noting this?

[tkent, 2016/05/20 01:00:30]

Done.

+  const char kFileScheme[] = "file:///";
+  const int kFileSchemeLen = arraysize(kFileScheme) - 1;
+  if (utf8_url.compare(0, kFileSchemeLen, kFileScheme, kFileSchemeLen) != 0)
+    return WebURL();
+#if defined(OS_WIN)
+  // +3 for a drive letter, :, and /.
+  const int kFileSchemeAndDriveLen = kFileSchemeLen + 3;
+  if (utf8_url.size() <= kFileSchemeAndDriveLen)
+    return WebURL();
+  std::string path = utf8_url.substr(kFileSchemeAndDriveLen);
+#else
+  std::string path = utf8_url.substr(kFileSchemeLen);
+#endif
+  // LayoutTests use file: URLs in various ways.
+  //  - The magic URL prefix "file:///tmp/LayoutTests/" to access file:
+  //    resources from http resources.
+  //  - $TMP to download a blob URL
+  //  - out/$CONFIG/gen/ and third_party/WebKit/Source/devtools to load
+  //    DevTools code.
+  // We rewite only a few patterns used in web-platform-tests because this is
+  // a short-teram workaround. We can remove this hack when we start to run

[qyearsley, 2016/05/18 17:26:56]

short-term

[tkent, 2016/05/20 01:00:30]

Removed.

+  // all WPT tests with wptserve.

[qyearsley, 2016/05/18 17:26:56]

Although, we may want to still want to have most tests run using file:// even if
when wptserve is used for the tests that require it; in that case, we may want
to keep this path rewriting in place.

[tkent, 2016/05/20 01:00:30]

I updated the comment.

+  if (base::StartsWith(path, "common/", base::CompareCase::SENSITIVE) ||
+      base::StartsWith(path, "images/", base::CompareCase::SENSITIVE) ||
+      base::StartsWith(path, "media/", base::CompareCase::SENSITIVE) ||
+      base::StartsWith(path, "resources/", base::CompareCase::SENSITIVE)) {
+    // TODO(tkent): web-platform-tests -> wpt when the renaming is completed.
+    base::FilePath new_path =
+        LayoutTestRenderThreadObserver::GetInstance()
+            ->webkit_source_dir()
+            .Append(
+                FILE_PATH_LITERAL("LayoutTests/imported/web-platform-tests/"))
+            .AppendASCII(path);
+    return WebURL(net::FilePathToFileURL(new_path));
+  }
+  return WebURL();
+}
+
 }  // namespace
 
 BlinkTestRunner::BlinkTestRunner(RenderView* render_view)
     : RenderViewObserver(render_view),
       RenderViewObserverTracker<BlinkTestRunner>(render_view),
       is_main_window_(false),
       focus_on_next_commit_(false),
       leak_detector_(new LeakDetector(this)) {
 }
 
@@ skipping 85 matching lines @@
         routing_id(), local_path, &contents));
 
   std::string contents_base64;
   base::Base64Encode(contents, &contents_base64);
 
   const char data_url_prefix[] = "data:text/css:charset=utf-8;base64,";
   return WebURL(GURL(data_url_prefix + contents_base64));
 }
 
 WebURL BlinkTestRunner::RewriteLayoutTestsURL(const std::string& utf8_url) {
+  WebURL url = RewriteAbsolutePathInWPT(utf8_url);

[qyearsley, 2016/05/18 17:26:56]

Would rewritten_url make sense for this variable name? Keeping it as url is also
fine if that seems better to you.

[tkent, 2016/05/20 01:00:30]

Done.

+  if (!url.isEmpty())
+    return url;
+
   const char kPrefix[] = "file:///tmp/LayoutTests/";
   const int kPrefixLen = arraysize(kPrefix) - 1;
 
   if (utf8_url.compare(0, kPrefixLen, kPrefix, kPrefixLen))
     return WebURL(GURL(utf8_url));
 
   base::FilePath replace_path =
       LayoutTestRenderThreadObserver::GetInstance()->webkit_source_dir()
           .Append(FILE_PATH_LITERAL("LayoutTests/"));
 #if defined(OS_WIN)
@@ skipping 632 matching lines @@
   get_bluetooth_events_callbacks_.pop_front();
   callback.Run(events);
 }
 
 void BlinkTestRunner::ReportLeakDetectionResult(
     const LeakDetectionResult& report) {
   Send(new ShellViewHostMsg_LeakDetectionDone(routing_id(), report));
 }
 
 }  // namespace content