Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1983913002: Test to see if we can bring in document data from Blink. (Closed)

Created:
4 years, 7 months ago by Avi (use Gerrit)
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, tyoshino+watch_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, blink-reviews-api_chromium.org, blink-reviews, dglazkov+blink, darin-cc_chromium.org, gavinp+loader_chromium.org, mkwst+moarreviews-renderer_chromium.org, Nate Chapin, loading-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Test to see if we can bring in document data from Blink. BUG=612260 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel

Patch Set 1 #

Patch Set 2 : true? #

Patch Set 3 : tristate #

Patch Set 4 : tristate #

Patch Set 5 : reload #

Patch Set 6 : createWindowForRequest #

Patch Set 7 : WebLocalFrameImpl::loadData #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -20 lines) Patch
M content/renderer/render_frame_impl.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoaderClient.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/NavigationScheduler.cpp View 1 2 3 4 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/page/CreateWindow.cpp View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 30 (16 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983913002/1
4 years, 7 months ago (2016-05-16 17:02:02 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/148670)
4 years, 7 months ago (2016-05-16 17:47:14 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983913002/20001
4 years, 7 months ago (2016-05-16 19:02:54 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/170827)
4 years, 7 months ago (2016-05-16 19:42:10 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983913002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983913002/40001
4 years, 7 months ago (2016-05-16 19:47:44 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/66680) mac_chromium_gn_rel on ...
4 years, 7 months ago (2016-05-16 19:59:03 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983913002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983913002/60001
4 years, 7 months ago (2016-05-16 20:37:02 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/170897) mac_chromium_rel_ng on ...
4 years, 7 months ago (2016-05-16 21:13:09 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983913002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983913002/80001
4 years, 7 months ago (2016-05-17 18:47:37 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/112661)
4 years, 7 months ago (2016-05-17 19:19:46 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983913002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983913002/100001
4 years, 7 months ago (2016-05-18 19:32:40 UTC) #23
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/113616)
4 years, 7 months ago (2016-05-18 20:02:51 UTC) #25
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983913002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983913002/120001
4 years, 7 months ago (2016-05-18 20:22:30 UTC) #28
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 21:24:03 UTC) #30
Dry run: Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

Powered by Google App Engine
This is Rietveld 408576698