third_party/WebKit/Source/core/page/CreateWindow.cpp - Issue 1983913002: Test to see if we can bring in document data from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/CreateWindow.cpp

Issue 1983913002: Test to see if we can bring in document data from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: WebLocalFrameImpl::loadData Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/NavigationScheduler.cpp ('k') | third_party/WebKit/Source/web/FrameLoaderClientImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/CreateWindow.cpp

diff --git a/third_party/WebKit/Source/core/page/CreateWindow.cpp b/third_party/WebKit/Source/core/page/CreateWindow.cpp

index 6b8f1697f905bf261c634a28d29602982326fca9..256fd5aa1be5158586467f695d644b4699d3855a 100644

--- a/third_party/WebKit/Source/core/page/CreateWindow.cpp

+++ b/third_party/WebKit/Source/core/page/CreateWindow.cpp

@@ -208,13 +208,13 @@ void createWindowForRequest(const FrameLoadRequest& request, LocalFrame& openerF

if (!newFrame)

return;

if (shouldSendReferrer == MaybeSendReferrer) {

- // TODO(japhet): Does ReferrerPolicy need to be proagated for RemoteFrames?

+ // TODO(japhet): Does ReferrerPolicy need to be propagated for RemoteFrames?

if (newFrame->isLocalFrame())

toLocalFrame(newFrame)->document()->setReferrerPolicy(openerFrame.document()->getReferrerPolicy());

}

// TODO(japhet): Form submissions on RemoteFrames don't work yet.

- FrameLoadRequest newRequest(0, request.resourceRequest());

+ FrameLoadRequest newRequest(request.originDocument(), request.resourceRequest());

newRequest.setForm(request.form());

if (newFrame->isLocalFrame())

toLocalFrame(newFrame)->loader().load(newRequest);