Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1983903002: Fix for Fullscreen toolbar with multiple monitors on OSX (Closed)

Created:
4 years, 7 months ago by spqchan
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Fix for Fullscreen toolbar with multiple monitors on OSX When checking for the active window during the menubar dropdown progress, use the isMainWindow property instead of onActiveSpace. If we have multiple monitors, onActiveSpace can return true, even if the window isn't active. BUG=606511 Review-Url: https://codereview.chromium.org/1979663002 Cr-Commit-Position: refs/heads/master@{#393642} (cherry picked from commit bde4e511c9b163ae0f2926a12834485cf9f6e996) Committed: https://chromium.googlesource.com/chromium/src/+/7ce0183043107443e995b20de48fdc6bf4381821

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M chrome/browser/ui/cocoa/presentation_mode_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/presentation_mode_controller.mm View 3 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
spqchan
4 years, 7 months ago (2016-05-16 17:02:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7ce0183043107443e995b20de48fdc6bf4381821.

Powered by Google App Engine
This is Rietveld 408576698