Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1979663002: Fix for Fullscreen toolbar with multiple monitors on OSX (Closed)

Created:
4 years, 7 months ago by spqchan
Modified:
4 years, 7 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for Fullscreen toolbar with multiple monitors on OSX When checking for the active window during the menubar dropdown progress, use the isMainWindow property instead of onActiveSpace. If we have multiple monitors, onActiveSpace can return true, even if the window isn't active. BUG=606511 Committed: https://crrev.com/bde4e511c9b163ae0f2926a12834485cf9f6e996 Cr-Commit-Position: refs/heads/master@{#393642}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M chrome/browser/ui/cocoa/presentation_mode_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/presentation_mode_controller.mm View 3 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
spqchan
PTAL
4 years, 7 months ago (2016-05-13 20:09:36 UTC) #5
Robert Sesek
lgtm
4 years, 7 months ago (2016-05-13 20:22:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979663002/1
4 years, 7 months ago (2016-05-13 20:24:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 21:09:53 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 21:11:16 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bde4e511c9b163ae0f2926a12834485cf9f6e996
Cr-Commit-Position: refs/heads/master@{#393642}

Powered by Google App Engine
This is Rietveld 408576698