chrome/browser/search/local_ntp_source.cc - Issue 1983773002: Cache SearchEngineType of TemplateURL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search/local_ntp_source.cc

Issue 1983773002: Cache SearchEngineType of TemplateURL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor-extracting-terms-from-template-url

Patch Set: Fix typo Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc ('k') | chrome/browser/ui/app_list/app_list_view_delegate.cc » ('j') | components/search_engines/prepopulated_engines.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/search/local_ntp_source.cc

diff --git a/chrome/browser/search/local_ntp_source.cc b/chrome/browser/search/local_ntp_source.cc

index d380865b3ddb9954986b338f4eb4032559c6c4ed..c54ae62a49e83be64ab5ef61cb48ba6abca47e90 100644

--- a/chrome/browser/search/local_ntp_source.cc

+++ b/chrome/browser/search/local_ntp_source.cc

@@ -29,7 +29,6 @@

#include "chrome/common/chrome_switches.h"

#include "chrome/common/url_constants.h"

#include "chrome/grit/generated_resources.h"

-#include "components/search_engines/template_url_prepopulate_data.h"

#include "components/search_engines/template_url_service.h"

#include "components/strings/grit/components_strings.h"

#include "grit/browser_resources.h"

@@ -88,8 +87,8 @@ bool DefaultSearchProviderIsGoogle(Profile* profile) {

const TemplateURL* default_provider =

template_url_service->GetDefaultSearchProvider();

return default_provider &&

- (TemplateURLPrepopulateData::GetEngineType(

- *default_provider, template_url_service->search_terms_data()) ==

+ (default_provider->GetEngineType(

+ template_url_service->search_terms_data()) ==

SEARCH_ENGINE_GOOGLE);

}