chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc - Issue 1983773002: Cache SearchEngineType of TemplateURL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc

Issue 1983773002: Cache SearchEngineType of TemplateURL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor-extracting-terms-from-template-url

Patch Set: Fix typo Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc

diff --git a/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc b/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc

index 18724573204b3bda33ef31494346026ad27a7705..39a0c0d07f633e9f5f0dbf1b4e7927b23b1f2753 100644

--- a/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc

+++ b/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc

@@ -48,7 +48,6 @@

#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h"

#include "components/google/core/browser/google_util.h"

#include "components/policy/core/common/cloud/policy_header_io_helper.h"

-#include "components/search_engines/template_url_prepopulate_data.h"

#include "components/search_engines/template_url_service.h"

#include "components/variations/net/variations_http_headers.h"

#include "content/public/browser/browser_thread.h"

@@ -313,8 +312,8 @@ void LogMainFrameMetricsOnUIThread(

template_url_service->GetDefaultSearchProvider();

if (!default_provider)

return;

- if (TemplateURLPrepopulateData::GetEngineType(

- *default_provider, template_url_service->search_terms_data()) ==

+ if (default_provider->GetEngineType(

+ template_url_service->search_terms_data()) ==

SearchEngineType::SEARCH_ENGINE_GOOGLE) {

if (net_error == net::OK) {

UMA_HISTOGRAM_LONG_TIMES("Net.NTP.Google.RequestTime2.Success",

« no previous file with comments | « no previous file | chrome/browser/search/local_ntp_source.cc » ('j') | components/search_engines/prepopulated_engines.json » ('J')