Issue 198333003: More sync of PRESUBMIT with what CQ runs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 198333003: More sync of PRESUBMIT with what CQ runs (Closed)

Created:
6 years, 9 months ago by Paweł Hajdan Jr.

Modified:
6 years, 9 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, sadrul, Ian Vollick, tfarina, haitaol+watch_chromium.org, piman+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, cc-bugs_chromium.org, erikwright+watch_chromium.org, danakj+watch_chromium.org, ben+ash_chromium.org, maniscalco+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

More sync of PRESUBMIT with what CQ runs This removes some configs that were here below in an attempt to reduce the tryserver load. They can be added later slowly after we verify they don't cause unnecessary load. Note that CQ was not checking them anyway, so they were losing at least 50% CL coverage. TBR=maruel BUG=317931 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256739

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -32 lines)			Patch
M	PRESUBMIT.py	View	3 chunks	+2 lines, -9 lines	0 comments	Download
M	ash/PRESUBMIT.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/PRESUBMIT.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	cc/PRESUBMIT.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/PRESUBMIT.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/policy/PRESUBMIT.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/PRESUBMIT.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/libgtk2ui/PRESUBMIT.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/PRESUBMIT.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/PRESUBMIT.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/net/PRESUBMIT.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	extensions/browser/PRESUBMIT.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	jingle/PRESUBMIT.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/PRESUBMIT.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	skia/PRESUBMIT.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sync/PRESUBMIT.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/compositor/PRESUBMIT.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

Committed patchset #1 manually as r256739 (tree was closed).

6 years, 9 months ago (2014-03-13 03:18:37 UTC) #1

Message was sent while issue was closed.

TBR

Expand Messages | Collapse Messages