Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: PRESUBMIT.py

Issue 198333003: More sync of PRESUBMIT with what CQ runs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | ash/PRESUBMIT.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 1305 matching lines...) Expand 10 before | Expand all | Expand 10 after
1316 'telemetry_unittests', 1316 'telemetry_unittests',
1317 ], 1317 ],
1318 'mac_chromium_compile_dbg': ['defaulttests'], 1318 'mac_chromium_compile_dbg': ['defaulttests'],
1319 'mac_chromium_rel': ['defaulttests'], 1319 'mac_chromium_rel': ['defaulttests'],
1320 'mac_nacl_sdk_build': ['compile'], 1320 'mac_nacl_sdk_build': ['compile'],
1321 'mac_rel': [ 1321 'mac_rel': [
1322 'telemetry_perf_unittests', 1322 'telemetry_perf_unittests',
1323 'telemetry_unittests', 1323 'telemetry_unittests',
1324 ], 1324 ],
1325 'win': ['compile'], 1325 'win': ['compile'],
1326 'win_chromium_compile_dbg': ['defaulttests'],
1326 'win_nacl_sdk_build': ['compile'], 1327 'win_nacl_sdk_build': ['compile'],
1327 'win_rel': standard_tests + [ 1328 'win_rel': standard_tests + [
1328 'app_list_unittests', 1329 'app_list_unittests',
1329 'ash_unittests', 1330 'ash_unittests',
1330 'aura_unittests', 1331 'aura_unittests',
1331 'cc_unittests', 1332 'cc_unittests',
1332 'chrome_elf_unittests', 1333 'chrome_elf_unittests',
1333 'chromedriver_unittests', 1334 'chromedriver_unittests',
1334 'components_unittests', 1335 'components_unittests',
1335 'compositor_unittests', 1336 'compositor_unittests',
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
1405 def GetPreferredTryMasters(project, change): 1406 def GetPreferredTryMasters(project, change):
1406 files = change.LocalPaths() 1407 files = change.LocalPaths()
1407 1408
1408 if not files or all(re.search(r'[\\/]OWNERS$', f) for f in files): 1409 if not files or all(re.search(r'[\\/]OWNERS$', f) for f in files):
1409 return {} 1410 return {}
1410 1411
1411 if all(re.search('\.(m|mm)$|(^|[/_])mac[/_.]', f) for f in files): 1412 if all(re.search('\.(m|mm)$|(^|[/_])mac[/_.]', f) for f in files):
1412 return GetDefaultTryConfigs([ 1413 return GetDefaultTryConfigs([
1413 'mac_chromium_compile_dbg', 1414 'mac_chromium_compile_dbg',
1414 'mac_chromium_rel', 1415 'mac_chromium_rel',
1415 'mac_rel'
1416 ]) 1416 ])
1417 if all(re.search('(^|[/_])win[/_.]', f) for f in files): 1417 if all(re.search('(^|[/_])win[/_.]', f) for f in files):
1418 return GetDefaultTryConfigs(['win', 'win_rel']) 1418 return GetDefaultTryConfigs(['win', 'win_rel'])
1419 if all(re.search('(^|[/_])android[/_.]', f) for f in files): 1419 if all(re.search('(^|[/_])android[/_.]', f) for f in files):
1420 return GetDefaultTryConfigs([ 1420 return GetDefaultTryConfigs([
1421 'android_aosp', 1421 'android_aosp',
1422 'android_clang_dbg', 1422 'android_clang_dbg',
1423 'android_dbg', 1423 'android_dbg',
1424 ]) 1424 ])
1425 if all(re.search('[/_]ios[/_.]', f) for f in files): 1425 if all(re.search('[/_]ios[/_.]', f) for f in files):
1426 return GetDefaultTryConfigs(['ios_rel_device', 'ios_dbg_simulator']) 1426 return GetDefaultTryConfigs(['ios_rel_device', 'ios_dbg_simulator'])
1427 1427
1428 builders = [ 1428 builders = [
1429 'android_clang_dbg', 1429 'android_clang_dbg',
1430 'android_dbg', 1430 'android_dbg',
1431 'ios_dbg_simulator', 1431 'ios_dbg_simulator',
1432 'ios_rel_device', 1432 'ios_rel_device',
1433 'linux_gtk',
1434 'linux_asan',
1435 'linux_chromium_chromeos_rel', 1433 'linux_chromium_chromeos_rel',
1436 'linux_chromium_clang_dbg', 1434 'linux_chromium_clang_dbg',
1437 'linux_nacl_sdk_build',
1438 'linux_chromium_rel', 1435 'linux_chromium_rel',
1439 'linux_rel',
1440 'mac_chromium_compile_dbg', 1436 'mac_chromium_compile_dbg',
1441 'mac_nacl_sdk_build',
1442 'mac_chromium_rel', 1437 'mac_chromium_rel',
1443 'mac_rel', 1438 'win_chromium_compile_dbg',
1444 'win',
1445 'win_nacl_sdk_build',
1446 'win_rel', 1439 'win_rel',
1447 'win_x64_rel', 1440 'win_x64_rel',
1448 ] 1441 ]
1449 1442
1450 # Match things like path/aura/file.cc and path/file_aura.cc. 1443 # Match things like path/aura/file.cc and path/file_aura.cc.
1451 # Same for chromeos. 1444 # Same for chromeos.
1452 if any(re.search('[/_](aura|chromeos)', f) for f in files): 1445 if any(re.search('[/_](aura|chromeos)', f) for f in files):
1453 builders.extend([ 1446 builders.extend([
1454 'linux_chromeos_asan', 1447 'linux_chromeos_asan',
1455 'linux_chromium_chromeos_clang_dbg' 1448 'linux_chromium_chromeos_clang_dbg'
1456 ]) 1449 ])
1457 1450
1458 # If there are gyp changes to base, build, or chromeos, run a full cros build 1451 # If there are gyp changes to base, build, or chromeos, run a full cros build
1459 # in addition to the shorter linux_chromeos build. Changes to high level gyp 1452 # in addition to the shorter linux_chromeos build. Changes to high level gyp
1460 # files have a much higher chance of breaking the cros build, which is 1453 # files have a much higher chance of breaking the cros build, which is
1461 # differnt from the linux_chromeos build that most chrome developers test 1454 # differnt from the linux_chromeos build that most chrome developers test
1462 # with. 1455 # with.
1463 if any(re.search('^(base|build|chromeos).*\.gypi?$', f) for f in files): 1456 if any(re.search('^(base|build|chromeos).*\.gypi?$', f) for f in files):
1464 builders.extend(['cros_x86']) 1457 builders.extend(['cros_x86'])
1465 1458
1466 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it 1459 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
1467 # unless they're .gyp(i) files as changes to those files can break the gyp 1460 # unless they're .gyp(i) files as changes to those files can break the gyp
1468 # step on that bot. 1461 # step on that bot.
1469 if (not all(re.search('^chrome', f) for f in files) or 1462 if (not all(re.search('^chrome', f) for f in files) or
1470 any(re.search('\.gypi?$', f) for f in files)): 1463 any(re.search('\.gypi?$', f) for f in files)):
1471 builders.extend(['android_aosp']) 1464 builders.extend(['android_aosp'])
1472 1465
1473 return GetDefaultTryConfigs(builders) 1466 return GetDefaultTryConfigs(builders)
OLDNEW
« no previous file with comments | « no previous file | ash/PRESUBMIT.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698