Replace ApplicationImpl::CreateApplicationConnector() with a standalone helper function.

Replace ApplicationImpl::CreateApplicationConnector() with a standalone helper function.

I want to hollow out ApplicationImpl.

Admittedly, even the standalone helper function adds little value over
just doing shell->CreateApplicationConnector(GetProxy(&foo)), though
it's nice in certain places to have a return value. (On the other hand,
you'll always get an InterfaceHandle, whereas you may have wanted an
InterfacePtr or SynchronousInterfacePtr.)

R=vardhan@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/1e926e4233a7e88039950e5b3212b19d5a63ff5a

[vardhan, 2016-05-17 20:46:21]

lgtm

[viettrungluu, 2016-05-17 21:01:37]

Description was changed from

==========
Replace ApplicationImpl::CreateApplicationConnector() with a standalone helper
function.

I want to hollow out ApplicationImpl.

Admittedly, even the standalone helper function adds little value over
just doing shell->CreateApplicationConnector(GetProxy(&foo)), though
it's nice in certain places to have a return value. (On the other hand,
you'll always get an InterfaceHandle, whereas you may have wanted an
InterfacePtr or SynchronousInterfacePtr.)

R=vardhan@google.com
==========

to

==========
Replace ApplicationImpl::CreateApplicationConnector() with a standalone helper
function.

I want to hollow out ApplicationImpl.

Admittedly, even the standalone helper function adds little value over
just doing shell->CreateApplicationConnector(GetProxy(&foo)), though
it's nice in certain places to have a return value. (On the other hand,
you'll always get an InterfaceHandle, whereas you may have wanted an
InterfacePtr or SynchronousInterfacePtr.)

R=vardhan@google.com

Committed:
https://chromium.googlesource.com/external/mojo/+/1e926e4233a7e88039950e5b321...
==========

[viettrungluu, 2016-05-17 21:01:39]

Committed patchset #1 (id:1) manually as
1e926e4233a7e88039950e5b3212b19d5a63ff5a (presubmit successful).