Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: mojo/public/cpp/application/application_impl.h

Issue 1983263002: Replace ApplicationImpl::CreateApplicationConnector() with a standalone helper function. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/cpp/application/BUILD.gn ('k') | mojo/public/cpp/application/application_test_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/application/application_impl.h
diff --git a/mojo/public/cpp/application/application_impl.h b/mojo/public/cpp/application/application_impl.h
index dd613f1736eca7fe48b51ea1dba8304901f1c767..68dc5657565f167d91fd42f8eda73087cd0cd470 100644
--- a/mojo/public/cpp/application/application_impl.h
+++ b/mojo/public/cpp/application/application_impl.h
@@ -12,7 +12,6 @@
#include "mojo/public/cpp/application/application_delegate.h"
#include "mojo/public/cpp/system/macros.h"
#include "mojo/public/interfaces/application/application.mojom.h"
-#include "mojo/public/interfaces/application/application_connector.mojom.h"
#include "mojo/public/interfaces/application/shell.mojom.h"
namespace mojo {
@@ -55,12 +54,6 @@ class ApplicationImpl : public Application {
const std::vector<std::string>& args() const { return args_; }
bool HasArg(const std::string& arg) const;
- // Creates a new |ApplicationConnector|. The result can be bound to an
- // |ApplicationConnectorPtr| and used to connect to other applications. (It
- // returns an |InterfaceHandle| instead of an |InterfacePtr| to facilitate
- // passing it to another thread.)
- InterfaceHandle<ApplicationConnector> CreateApplicationConnector();
-
// Blocks until the |Application| is initialized (i.e., |Initialize()| is
// received), if it is not already.
void WaitForInitialize();
@@ -84,7 +77,7 @@ class ApplicationImpl : public Application {
private:
std::vector<std::unique_ptr<ServiceProviderImpl>> service_provider_impls_;
ApplicationDelegate* delegate_;
- Binding<Application> binding_;
+ Binding<Application> application_binding_;
ShellPtr shell_;
std::string url_;
std::vector<std::string> args_;
« no previous file with comments | « mojo/public/cpp/application/BUILD.gn ('k') | mojo/public/cpp/application/application_test_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698