Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1983243003: Update FromGoogleSearch page load metrics to log immediately (Closed)

Created:
4 years, 7 months ago by Bryan McQuade
Modified:
4 years, 7 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update FromGoogleSearch page load metrics observer to log timing events immediately. This change also changes the client name string to be easier for UMA dashboard users to understand, from FromGWS2 to FromGoogleSearch. BUG=612547 Committed: https://crrev.com/4c7da080bdf3c920d7ccd35ce3821ba6ccbeefda Cr-Commit-Position: refs/heads/master@{#394516}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -78 lines) Patch
M chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h View 4 chunks +57 lines, -9 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc View 6 chunks +172 lines, -67 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc View 2 chunks +53 lines, -1 line 0 comments Download
M chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +29 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
Bryan McQuade
PTAL
4 years, 7 months ago (2016-05-17 19:29:21 UTC) #3
Bryan McQuade
On 2016/05/17 at 19:29:21, Bryan McQuade wrote: > PTAL One comment here: now that we ...
4 years, 7 months ago (2016-05-18 12:15:43 UTC) #4
Charlie Harrison
This lgtm.
4 years, 7 months ago (2016-05-18 15:23:44 UTC) #5
Bryan McQuade
rkaplow, PTAL for histograms.xml, thanks!
4 years, 7 months ago (2016-05-18 15:42:03 UTC) #7
rkaplow
lgtm
4 years, 7 months ago (2016-05-18 19:37:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1983243003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1983243003/20001
4 years, 7 months ago (2016-05-18 19:51:35 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-18 19:56:55 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 19:58:44 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4c7da080bdf3c920d7ccd35ce3821ba6ccbeefda
Cr-Commit-Position: refs/heads/master@{#394516}

Powered by Google App Engine
This is Rietveld 408576698