chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc - Issue 1983243003: Update FromGoogleSearch page load metrics to log immediately

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

Issue 1983243003: Update FromGoogleSearch page load metrics to log immediately (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

diff --git a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

index 26a700d976130c22c7faf9a71d35c734755356d2..bd95836309aacaf22e8f4e2e91ea502ec65e07ad 100644

--- a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

+++ b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

@@ -76,6 +76,14 @@ void PageLoadMetricsObserverTestHarness::PopulateRequiredTimingFields(

inout_timing->dom_loading.is_zero()) {

inout_timing->dom_loading = inout_timing->dom_content_loaded_event_start;

}

+ if (!inout_timing->parse_stop.is_zero() &&

+ inout_timing->parse_start.is_zero()) {

+ inout_timing->parse_start = inout_timing->parse_stop;

+ }

+ if (!inout_timing->parse_start.is_zero() &&

+ inout_timing->response_start.is_zero()) {

+ inout_timing->response_start = inout_timing->parse_start;

+ }

if (!inout_timing->dom_loading.is_zero() &&

inout_timing->response_start.is_zero()) {

inout_timing->response_start = inout_timing->dom_loading;