Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3296)

Unified Diff: chrome/browser/ui/translate/translate_bubble_view_state_transition.h

Issue 1983133003: change the value of SET_STATE_OPTIONS back to 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/translate/translate_bubble_view_state_transition.h
diff --git a/chrome/browser/ui/translate/translate_bubble_view_state_transition.h b/chrome/browser/ui/translate/translate_bubble_view_state_transition.h
index fd5382d9ae25da0977006e0f71e98dc2023fd893..8f13e28209b230433a8398293dcd559dda9d264e 100644
--- a/chrome/browser/ui/translate/translate_bubble_view_state_transition.h
+++ b/chrome/browser/ui/translate/translate_bubble_view_state_transition.h
@@ -12,7 +12,11 @@ namespace translate {
enum TranslateBubbleUiEvent {
// The user clicked the advanced option.
- SET_STATE_OPTIONS,
+ // The value need to be set to 1 since it was defined as 1 in the .cc
msw 2016/05/17 20:40:43 This comment is really unnecessary and doesn't fol
+ // file since https://codereview.chromium.org/1586233003
+ // which landed at 2/26/2016. Keep it as 1 will matain the consistency between
+ // versions.
+ SET_STATE_OPTIONS = 1,
// The user clicked "Done" and went back from the advanced option.
LEAVE_STATE_OPTIONS,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698