Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Side by Side Diff: chrome/browser/ui/translate/translate_bubble_view_state_transition.h

Issue 1983133003: change the value of SET_STATE_OPTIONS back to 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_TRANSLATE_TRANSLATE_BUBBLE_VIEW_STATE_TRANSITION_H_ 5 #ifndef CHROME_BROWSER_UI_TRANSLATE_TRANSLATE_BUBBLE_VIEW_STATE_TRANSITION_H_
6 #define CHROME_BROWSER_UI_TRANSLATE_TRANSLATE_BUBBLE_VIEW_STATE_TRANSITION_H_ 6 #define CHROME_BROWSER_UI_TRANSLATE_TRANSLATE_BUBBLE_VIEW_STATE_TRANSITION_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "chrome/browser/ui/translate/translate_bubble_model.h" 9 #include "chrome/browser/ui/translate/translate_bubble_model.h"
10 10
11 namespace translate { 11 namespace translate {
12 12
13 enum TranslateBubbleUiEvent { 13 enum TranslateBubbleUiEvent {
14 // The user clicked the advanced option. 14 // The user clicked the advanced option.
15 SET_STATE_OPTIONS, 15 // The value need to be set to 1 since it was defined as 1 in the .cc
msw 2016/05/17 20:40:43 This comment is really unnecessary and doesn't fol
16 // file since https://codereview.chromium.org/1586233003
17 // which landed at 2/26/2016. Keep it as 1 will matain the consistency between
18 // versions.
19 SET_STATE_OPTIONS = 1,
16 20
17 // The user clicked "Done" and went back from the advanced option. 21 // The user clicked "Done" and went back from the advanced option.
18 LEAVE_STATE_OPTIONS, 22 LEAVE_STATE_OPTIONS,
19 23
20 // The user clicked the advanced link. 24 // The user clicked the advanced link.
21 ADVANCED_LINK_CLICKED, 25 ADVANCED_LINK_CLICKED,
22 26
23 // The user checked the "always translate" checkbox. 27 // The user checked the "always translate" checkbox.
24 ALWAYS_TRANSLATE_CHECKED, 28 ALWAYS_TRANSLATE_CHECKED,
25 29
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 // The view type. When the current view type is not 'Advanced' view, this is 102 // The view type. When the current view type is not 'Advanced' view, this is
99 // equivalent to |view_state_|. Otherwise, this is the previous view type 103 // equivalent to |view_state_|. Otherwise, this is the previous view type
100 // before the user opens the 'Advanced' view. This is used to navigate when 104 // before the user opens the 'Advanced' view. This is used to navigate when
101 // pressing 'Cancel' button on the 'Advanced' view. 105 // pressing 'Cancel' button on the 'Advanced' view.
102 TranslateBubbleModel::ViewState view_state_before_advanced_view_; 106 TranslateBubbleModel::ViewState view_state_before_advanced_view_;
103 107
104 DISALLOW_COPY_AND_ASSIGN(TranslateBubbleViewStateTransition); 108 DISALLOW_COPY_AND_ASSIGN(TranslateBubbleViewStateTransition);
105 }; 109 };
106 110
107 #endif // CHROME_BROWSER_UI_TRANSLATE_TRANSLATE_BUBBLE_VIEW_STATE_TRANSITION_H_ 111 #endif // CHROME_BROWSER_UI_TRANSLATE_TRANSLATE_BUBBLE_VIEW_STATE_TRANSITION_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698