change the value of SET_STATE_OPTIONS back to 1

in cl/1923143003 (landed 5/4/2016) I mistakenly change the value of SET_STATE_OPTIONS from 1 to 0. Need to change it back to 1 before the next release.

BUG=612558
Committed: https://crrev.com/4bda0372b8eae09293604a98c0c96b74ed23c4bf
Cr-Commit-Position: refs/heads/master@{#394301}

[ftang, 2016-05-17 19:39:41]

The CQ bit was checked by ftang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-17 19:40:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1983133003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1983133003/1

[ftang, 2016-05-17 19:40:40]

Description was changed from

==========
in cl/1923143003 (landed 5/4/2016) I mistakenly change the value of
SET_STATE_OPTIONS from 1 to 0. Need to change it back before the next release

BUG=612558
==========

to

==========
in cl/1923143003 (landed 5/4/2016) I mistakenly change the value of
SET_STATE_OPTIONS from 1 to 0. Need to change it back to 1 before the next
release.

BUG=612558
==========

[ftang, 2016-05-17 19:40:41]

ftang@chromium.org changed reviewers:
+ groby@chromium.org

[ftang, 2016-05-17 19:41:08]

This is high priority. Please review. Sorry for my mistake.

[groby-ooo-7-16, 2016-05-17 19:44:07]

LGTM % nit

https://codereview.chromium.org/1983133003/diff/1/chrome/browser/ui/translate...
File chrome/browser/ui/translate/translate_bubble_view_state_transition.h
(right):

https://codereview.chromium.org/1983133003/diff/1/chrome/browser/ui/translate...
chrome/browser/ui/translate/translate_bubble_view_state_transition.h:15:
SET_STATE_OPTIONS = 1,
Please add a comment why we need to force this to 1.

[ftang, 2016-05-17 19:49:34]

add comments

[ftang, 2016-05-17 19:49:59]

The CQ bit was checked by ftang@chromium.org

[ftang, 2016-05-17 19:49:59]

The patchset sent to the CQ was uploaded after l-g-t-m from groby@chromium.org
Link to the patchset: https://codereview.chromium.org/1983133003/#ps20001
(title: "add comments")

[commit-bot: I haz the power, 2016-05-17 19:50:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1983133003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1983133003/20001

[commit-bot: I haz the power, 2016-05-17 20:04:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 20:04:33]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[groby-ooo-7-16, 2016-05-17 20:17:00]

groby@chromium.org changed reviewers:
+ msw@chromium.org

[groby-ooo-7-16, 2016-05-17 20:19:18]

On 2016/05/17 20:04:33, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

msw: PTAL, and please comment on OWNERS proposal below.
ftang: Oy - c/b/ui/translate doesn't have an OWNERS, so you need c/b/ui. I've
added msw. Also, I suggest adding that OWNERS file in a separate CL, with the
contents 
    file://components/translate/OWNERS 

Same as all other translate OWNERS. And then send to msw for review.

[msw, 2016-05-17 20:40:43]

The new owners file sgtm; I hope that the owners will help maintain a high
standard for the code and comments therein! (eg. the comment added here is a bit
atypical and warranting feedback/guidance)

https://codereview.chromium.org/1983133003/diff/20001/chrome/browser/ui/trans...
File chrome/browser/ui/translate/translate_bubble_view_state_transition.h
(right):

https://codereview.chromium.org/1983133003/diff/20001/chrome/browser/ui/trans...
chrome/browser/ui/translate/translate_bubble_view_state_transition.h:15: // The
value need to be set to 1 since it was defined as 1 in the .cc
This comment is really unnecessary and doesn't follow typical chromium
commenting patterns; remove the comment altogether or replace it with:
// Start with 1 to match existing UMA values: see http://crbug.com/612558

[ftang, 2016-05-17 20:59:12]

change comments per msw

[ftang, 2016-05-17 20:59:26]

PTAL

[msw, 2016-05-17 21:14:12]

lgtm with a nit

https://codereview.chromium.org/1983133003/diff/40001/chrome/browser/ui/trans...
File chrome/browser/ui/translate/translate_bubble_view_state_transition.h
(right):

https://codereview.chromium.org/1983133003/diff/40001/chrome/browser/ui/trans...
chrome/browser/ui/translate/translate_bubble_view_state_transition.h:14: //
Start with 1 to match existing UMA value: see http://crbug.com/612558
nit: values

[ftang, 2016-05-17 22:38:27]

clena up the comment

[ftang, 2016-05-17 22:39:04]

The CQ bit was checked by ftang@chromium.org

[ftang, 2016-05-17 22:39:04]

The patchset sent to the CQ was uploaded after l-g-t-m from groby@chromium.org,
msw@chromium.org
Link to the patchset: https://codereview.chromium.org/1983133003/#ps60001
(title: "clean up the comment")

[commit-bot: I haz the power, 2016-05-17 22:39:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1983133003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1983133003/60001

[commit-bot: I haz the power, 2016-05-18 00:56:05]

Description was changed from

==========
in cl/1923143003 (landed 5/4/2016) I mistakenly change the value of
SET_STATE_OPTIONS from 1 to 0. Need to change it back to 1 before the next
release.

BUG=612558
==========

to

==========
in cl/1923143003 (landed 5/4/2016) I mistakenly change the value of
SET_STATE_OPTIONS from 1 to 0. Need to change it back to 1 before the next
release.

BUG=612558
==========

[commit-bot: I haz the power, 2016-05-18 00:56:06]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-18 00:57:36]

Description was changed from

==========
in cl/1923143003 (landed 5/4/2016) I mistakenly change the value of
SET_STATE_OPTIONS from 1 to 0. Need to change it back to 1 before the next
release.

BUG=612558
==========

to

==========
in cl/1923143003 (landed 5/4/2016) I mistakenly change the value of
SET_STATE_OPTIONS from 1 to 0. Need to change it back to 1 before the next
release.

BUG=612558

Committed: https://crrev.com/4bda0372b8eae09293604a98c0c96b74ed23c4bf
Cr-Commit-Position: refs/heads/master@{#394301}
==========

[commit-bot: I haz the power, 2016-05-18 00:57:37]

Patchset 4 (id:??) landed as
https://crrev.com/4bda0372b8eae09293604a98c0c96b74ed23c4bf
Cr-Commit-Position: refs/heads/master@{#394301}