chrome/android/javatests/src/org/chromium/chrome/browser/snackbar/SnackbarTest.java - Issue 1982803002: Record UMA for snackbars shown for all purposes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/snackbar/SnackbarTest.java

Issue 1982803002: Record UMA for snackbars shown for all purposes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: make identifier a parameter in constructor Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/snackbar/undo/UndoBarController.java ('k') | chrome/android/junit/src/org/chromium/chrome/browser/snackbar/SnackbarCollectionUnitTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/snackbar/SnackbarTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/snackbar/SnackbarTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/snackbar/SnackbarTest.java

index 74ff937a9f70b0c32dcea6cbe4e88c6169d06cb1..994838b7491625d9e92e68279720ea2e756e5103 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/snackbar/SnackbarTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/snackbar/SnackbarTest.java

@@ -38,9 +38,9 @@ public class SnackbarTest extends ChromeTabbedActivityTestBase {

@MediumTest

public void testStackQueueOrder() throws InterruptedException {

final Snackbar stackbar = Snackbar.make("stack", mDefaultController,

- Snackbar.TYPE_ACTION);

+ Snackbar.TYPE_ACTION, Snackbar.UMA_TEST_SNACKBAR);

final Snackbar queuebar = Snackbar.make("queue", mDefaultController,

- Snackbar.TYPE_NOTIFICATION);

+ Snackbar.TYPE_NOTIFICATION, Snackbar.UMA_TEST_SNACKBAR);

ThreadUtils.runOnUiThread(new Runnable() {

@Override

public void run() {

@@ -79,9 +79,9 @@ public class SnackbarTest extends ChromeTabbedActivityTestBase {

@SmallTest

public void testQueueStackOrder() throws InterruptedException {