chrome/android/java/src/org/chromium/chrome/browser/snackbar/undo/UndoBarController.java - Issue 1982803002: Record UMA for snackbars shown for all purposes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/snackbar/undo/UndoBarController.java

Issue 1982803002: Record UMA for snackbars shown for all purposes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: make identifier a parameter in constructor Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/snackbar/smartlockautosignin/AutoSigninSnackbarController.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/snackbar/SnackbarTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/snackbar/undo/UndoBarController.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/undo/UndoBarController.java b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/undo/UndoBarController.java

index a1d7bae7b1d0801b5df024381022fd5086963ab8..2c087f40df23e20f24ef00394478c4453e701a64 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/undo/UndoBarController.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/undo/UndoBarController.java

@@ -127,9 +127,10 @@ public class UndoBarController implements SnackbarManager.SnackbarController {

mSnackbarManager.isShowing() ? TAB_CLOSE_UNDO_TOAST_SHOWN_WARM

: TAB_CLOSE_UNDO_TOAST_SHOWN_COLD,

TAB_CLOSE_UNDO_TOAST_COUNT);

- mSnackbarManager.showSnackbar(Snackbar.make(content, this, Snackbar.TYPE_ACTION)

- .setTemplateText(mContext.getString(R.string.undo_bar_close_message))

- .setAction(mContext.getString(R.string.undo), tabId));

+ mSnackbarManager.showSnackbar(

+ Snackbar.make(content, this, Snackbar.TYPE_ACTION, Snackbar.UMA_TAB_CLOSE_UNDO)

+ .setTemplateText(mContext.getString(R.string.undo_bar_close_message))

+ .setAction(mContext.getString(R.string.undo), tabId));

}

/**

@@ -142,7 +143,8 @@ public class UndoBarController implements SnackbarManager.SnackbarController {

private void showUndoCloseAllBar(List<Integer> closedTabIds) {

String content = String.format(Locale.getDefault(), "%d", closedTabIds.size());

- mSnackbarManager.showSnackbar(Snackbar.make(content, this, Snackbar.TYPE_ACTION)

+ mSnackbarManager.showSnackbar(

+ Snackbar.make(content, this, Snackbar.TYPE_ACTION, Snackbar.UMA_TAB_CLOSE_ALL_UNDO)

.setTemplateText(mContext.getString(R.string.undo_bar_close_all_message))

.setAction(mContext.getString(R.string.undo), closedTabIds));