chrome/android/java/src/org/chromium/chrome/browser/snackbar/LofiBarController.java - Issue 1982803002: Record UMA for snackbars shown for all purposes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/snackbar/LofiBarController.java

Issue 1982803002: Record UMA for snackbars shown for all purposes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: make identifier a parameter in constructor Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/snackbar/LofiBarController.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/LofiBarController.java b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/LofiBarController.java

index 5a5c4d04ffd0abba6d2ed181ec8aa7107a83d911..5cdc56195077ad3d34e36a1aa67e215325af7e2d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/LofiBarController.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/LofiBarController.java

@@ -100,9 +100,10 @@ public class LofiBarController implements SnackbarManager.SnackbarController {

.getString(isPreview ? R.string.data_reduction_lo_fi_preview_snackbar_action

: R.string.data_reduction_lo_fi_snackbar_action);

- mSnackbarManager.showSnackbar(Snackbar.make(message, this, Snackbar.TYPE_NOTIFICATION)

- .setAction(buttonText, isPreview ? PREVIEW_SNACKBAR : LOFI_SNACKBAR)

- .setDuration(DEFAULT_LO_FI_SNACKBAR_SHOW_DURATION_MS));

+ mSnackbarManager.showSnackbar(

+ Snackbar.make(message, this, Snackbar.TYPE_NOTIFICATION, Snackbar.UMA_LOFI)

+ .setAction(buttonText, isPreview ? PREVIEW_SNACKBAR : LOFI_SNACKBAR)

+ .setDuration(DEFAULT_LO_FI_SNACKBAR_SHOW_DURATION_MS));

DataReductionProxySettings.getInstance().incrementLoFiSnackbarShown();

DataReductionProxyUma.dataReductionProxyLoFiUIAction(

DataReductionProxyUma.ACTION_LOAD_IMAGES_SNACKBAR_SHOWN);