chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java - Issue 1982803002: Record UMA for snackbars shown for all purposes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java

Issue 1982803002: Record UMA for snackbars shown for all purposes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: make identifier a parameter in constructor Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationSnackbarController.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/snackbar/LofiBarController.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java

index bdd2248f00f65c8cf3b08a785d4352fc87ec5d51..f731e10116b2425392fae195be4e36500b622a65 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java

@@ -44,13 +44,14 @@ public class DataUseSnackbarController implements SnackbarManager.SnackbarContro

public void showDataUseTrackingStartedBar() {

assert DataUseTabUIManager.shouldShowDataUseStartedUI();

- mSnackbarManager.showSnackbar(

- Snackbar.make(DataUseTabUIManager.getDataUseUIString(

- DataUseUIMessage.DATA_USE_TRACKING_STARTED_SNACKBAR_MESSAGE),

- this, Snackbar.TYPE_NOTIFICATION)

- .setAction(DataUseTabUIManager.getDataUseUIString(

- DataUseUIMessage.DATA_USE_TRACKING_SNACKBAR_ACTION),

- STARTED_SNACKBAR));

+ mSnackbarManager.showSnackbar(Snackbar

+ .make(DataUseTabUIManager.getDataUseUIString(

+ DataUseUIMessage.DATA_USE_TRACKING_STARTED_SNACKBAR_MESSAGE), this,

+ Snackbar.TYPE_NOTIFICATION, Snackbar.UMA_DATA_USE_STARTED)

+ .setAction(

+ DataUseTabUIManager.getDataUseUIString(

+ DataUseUIMessage.DATA_USE_TRACKING_SNACKBAR_ACTION),

+ STARTED_SNACKBAR));

DataUseTabUIManager.recordDataUseUIAction(DataUsageUIAction.STARTED_SNACKBAR_SHOWN);

}

@@ -64,7 +65,7 @@ public class DataUseSnackbarController implements SnackbarManager.SnackbarContro

mSnackbarManager.showSnackbar(

Snackbar.make(DataUseTabUIManager.getDataUseUIString(

DataUseUIMessage.DATA_USE_TRACKING_ENDED_SNACKBAR_MESSAGE),

- this, Snackbar.TYPE_NOTIFICATION)

+ this, Snackbar.TYPE_NOTIFICATION, Snackbar.UMA_DATA_USE_ENDED)

.setAction(DataUseTabUIManager.getDataUseUIString(

DataUseUIMessage.DATA_USE_TRACKING_SNACKBAR_ACTION),

ENDED_SNACKBAR));